Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PRs that get master back to good state #6037

Closed
mkonicek opened this issue Feb 19, 2016 · 5 comments
Closed

Merge PRs that get master back to good state #6037

mkonicek opened this issue Feb 19, 2016 · 5 comments
Assignees
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@mkonicek
Copy link
Contributor

Creating this issue purely to track everything that's remaining to get master back to good state:

The e2e test on Travis has been consistently failing for several days:
https://travis-ci.org/facebook/react-native/builds

My understanding is the root cause is the interaction between these two PRs (reverting both makes npm install from master and running an app work again): #5812 (7586951), #5813 (9f01f96).

The following PRs should get us back to good state: #6039 (depends on facebookarchive/node-haste#33) and #5084. Possibly also #6040.

@skevy
Copy link
Contributor

skevy commented Feb 26, 2016

This one too: #5811

Updates Babel to 6.5.x, which has a ton of bug fixes, and also puts React in "devDependencies" (in addition to peer) so that it works properly in Travis/Circle.

@skevy
Copy link
Contributor

skevy commented Feb 26, 2016

@bestander if you run into trouble when trying out npm 3.7, it's most likely because React needs to be a dev dep, which is fixed in that PR ^^ :)

@bestander
Copy link
Contributor

👍

@grabbou
Copy link
Contributor

grabbou commented Apr 26, 2016

Is there anything else to do on this issue? I have just checked and all PRs mentioned here were either closed or merged and master itself seems to be good again (more or less, but failures are not related to the deps as here)

@satya164
Copy link
Contributor

I guess it should be good to close. Please re-open if 'm wrong.

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants