-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge PRs that get master back to good state #6037
Comments
This one too: #5811 Updates Babel to 6.5.x, which has a ton of bug fixes, and also puts React in "devDependencies" (in addition to peer) so that it works properly in Travis/Circle. |
@bestander if you run into trouble when trying out npm 3.7, it's most likely because React needs to be a dev dep, which is fixed in that PR ^^ :) |
👍 |
Is there anything else to do on this issue? I have just checked and all PRs mentioned here were either closed or merged and master itself seems to be good again (more or less, but failures are not related to the deps as here) |
I guess it should be good to close. Please re-open if 'm wrong. |
Creating this issue purely to track everything that's remaining to get master back to good state:
The e2e test on Travis has been consistently failing for several days:
https://travis-ci.org/facebook/react-native/builds
My understanding is the root cause is the interaction between these two PRs (reverting both makes
npm install
from master and running an app work again): #5812 (7586951), #5813 (9f01f96).The following PRs should get us back to good state: #6039 (depends on facebookarchive/node-haste#33) and #5084. Possibly also #6040.
The text was updated successfully, but these errors were encountered: