Abstract away use of shadow nodes as native node references #49009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67704855 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 28, 2025
…#49009) Summary: Changelog: [internal] Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently. This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document. Differential Revision: D67704855
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
…facebook#49009) Summary: Changelog: [internal] Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently. This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document. Reviewed By: javache Differential Revision: D67704855
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
…facebook#49009) Summary: Changelog: [internal] Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently. This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document. Reviewed By: javache Differential Revision: D67704855
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
…#49009) Summary: Changelog: [internal] Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently. This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document. Reviewed By: javache Differential Revision: D67704855
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
…facebook#49009) Summary: Changelog: [internal] Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently. This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document. Reviewed By: javache Differential Revision: D67704855
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
…#49009) Summary: Changelog: [internal] Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently. This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document. Reviewed By: javache Differential Revision: D67704855
rubennorte
force-pushed
the
export-D67704855
branch
from
3569ec5 to
3631ff8
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
…facebook#49009) Summary: Changelog: [internal] Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently. This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document. Reviewed By: javache Differential Revision: D67704855
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
…facebook#49009) Summary: Changelog: [internal] Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently. This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document. Reviewed By: javache Differential Revision: D67704855
Summary: Changelog: [internal] We're modifying some core APIs in the RN render in following diffs, so this adds a simple benchmark as a safety mechanism to verify those don't regress performance significantly. Reviewed By: yungsters Differential Revision: D68772175
…#49009) Summary: Changelog: [internal] Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently. This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document. Reviewed By: javache Differential Revision: D67704855
rubennorte
force-pushed
the
export-D67704855
branch
from
3631ff8 to
3b28a25
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67704855 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
…facebook#49009) Summary: Changelog: [internal] Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently. This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document. Reviewed By: javache Differential Revision: D67704855
|
This pull request has been merged in 7cdc3d8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its
documentElement, we don't have an instance handle from React that links to the node, but we're going to represent that differently.This is a refactor so the existing methods use a mostly opaque
NativeNodeReferencetype so we can implement it as a union of React instance handles and the future types we're going to introduce to support document.Differential Revision: D67704855