Migrated Alert/*.js and ActionSheetIOS/*.js to use export syntax.
#48703
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Alert and Libraries/ActionSheetIOS to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the related modules - Updates the public API snapshot (intented breaking change) Changelog: [General][Breaking] - Files inside `Libraries/Alert` and `Libraries/ActionSheetIOS` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68210738
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68210738 |
|
This pull request has been merged in c89c5d7. |
|
This pull request was successfully merged by @iwoplaza in c89c5d7 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation
Modernising the react-native codebase to allow for ingestion by modern Flow tooling
This diff
exportsyntaxexport defaultfor qualified objects, manyexportstatements for collections (determined by how it's imported).defaultto requires of the changed files.Changelog:
[General][Breaking] - Files inside
Libraries/AlertandLibraries/ActionSheetIOSuseexportsyntax, which requires the addition of.defaultwhen imported with the CJSrequiresyntax.Differential Revision: D68210738