Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating AppDelegate.mm to AppDelegate.swift in RN 0.77 #48681

Closed
maksymhcode-care opened this issue Jan 15, 2025 · 3 comments
Closed

Migrating AppDelegate.mm to AppDelegate.swift in RN 0.77 #48681

maksymhcode-care opened this issue Jan 15, 2025 · 3 comments
Labels
Resolution: Answered When the issue is resolved with a simple answer

Comments

@maksymhcode-care
Copy link

maksymhcode-care commented Jan 15, 2025

Description

Can someone explain if converting AppDelegate to swift is mandatory for 0.77? i still have dependencies that might never be updated for 0.77 and i'm not sure what to do with the methods that i added to AppDelegate.mm

Steps to reproduce

  1. Something like react-native-notifications looks to be abandoned, but requires you to add necessary methods inside AppDelegate.mm

Image

React Native Version

0.77.0-rc.6

Affected Platforms

Build - MacOS

Output of npx react-native info

None

Stacktrace or Logs

None

Screenshots and Videos

No response

@react-native-bot react-native-bot added Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Jan 15, 2025
@react-native-bot
Copy link
Collaborator

Warning

Missing reproducer: We could not detect a reproducible example in your issue report. Please provide either:

@maksymhcode-care maksymhcode-care changed the title Migratint AppDelegate.mm to AppDelegate.swift in RN 0.77 Migrating AppDelegate.mm to AppDelegate.swift in RN 0.77 Jan 15, 2025
@cipolleschi
Copy link
Contributor

@maksymhcode-care Thanks for the question. Everything will be clarified in the blogpost we are going to publish as soon as 0.77 is released as stable.

However, no, migrating the AppDelegate to swift is not mandatory. We will continue supporting both the Objective-C and the Swift template.

Note that the changes you are mentioning for react-native-notifications should be ported as they are in Swift, just by changing the syntax: any objective-C code can be used in Swift as long as you can import RNNotifications.

@maksymhcode-care
Copy link
Author

@maksymhcode-care Thanks for the question. Everything will be clarified in the blogpost we are going to publish as soon as 0.77 is released as stable.

However, no, migrating the AppDelegate to swift is not mandatory. We will continue supporting both the Objective-C and the Swift template.

Note that the changes you are mentioning for react-native-notifications should be ported as they are in Swift, just by changing the syntax: any objective-C code can be used in Swift as long as you can import RNNotifications.

Thank you

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels Jan 15, 2025
@cortinico cortinico added Resolution: Answered When the issue is resolved with a simple answer and removed Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Needs: Attention Issues where the author has responded to feedback. labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Answered When the issue is resolved with a simple answer
Projects
None yet
Development

No branches or pull requests

4 participants