Move experimental_boxShadow and experimental_backgroundImage to BaseViewConfig
#46197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aseViewConfig Summary: RN Android has historically delegated any responsibilities for background and border rendering to individual view managers. When we enforced that SVCs didn't apply to more than native view configs, it meant that unlike for iOS, we needed to structure these SVCs to only apply to single view managers, to avoid warnings. This creates issues for third-party view managers extending the built in ones, which don't get these added to their SVCs under current setup it seems. After we clean up an old experiment path (waiting a little bit longer for safety), BaseViewManager on Android will be able to influence rendering, and we can put these in BaseViewManager (see D61658737). In the meantime, D60575253 allows us to make SVCs a superset of native view config, which means we can declare this for `BaseViewConfig`, before Java view managers catch up, without creating warnings. Changelog: [Android][Changed] - Move `experimental_boxShadow` and `experimental_backgroundImage` to BaseViewConfig Differential Revision: D61744706
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61744706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RN Android has historically delegated any responsibilities for background and border rendering to individual view managers.
When we enforced that SVCs didn't apply to more than native view configs, it meant that unlike for iOS, we needed to structure these SVCs to only apply to single view managers, to avoid warnings.
This creates issues for third-party view managers extending the built in ones, which don't get these added to their SVCs under current setup it seems.
After we clean up an old experiment path (waiting a little bit longer for safety), BaseViewManager on Android will be able to influence rendering, and we can put these in BaseViewManager (see D61658737).
In the meantime, D60575253 allows us to make SVCs a superset of native view config, which means we can declare this for
BaseViewConfig, before Java view managers catch up, without creating warnings.Changelog:
[Android][Changed] - Move
experimental_boxShadowandexperimental_backgroundImageto BaseViewConfigDifferential Revision: D61744706