Add children to separate _containerView, if needed #46189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61414649 |
|
This pull request was exported from Phabricator. Differential Revision: D61414649 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Aug 23, 2024
Summary: Pull Request resolved: facebook#46189 A lot of the style decorators we have (filters, box shadows, borders, etc) use a separate sub-CALayer to accomplish what they want. This becomes an issue if we are clipping the content to the bounds and if these decorators extend beyond the bounds of the view as they are typically unaffected by this clipping. The main things here are `box-shadow` and `outline`. However, this implementation will let us fix some issues w.r.t content rendering under borders. See later diffs for that. To fix this, if needed, we insert a `_containerView` to contain all of our subviews, and actually apply the clipping to. If this exists, our UIView will only have one subview, this one. But it may have multiple sublayers. NOTE: This diff does not actually redirect the clipping. It just inserts the subview to test if this breaks anything in and of itself. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D61414649
joevilches
force-pushed
the
export-D61414649
branch
from
f60dbd4 to
dab820e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61414649 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Aug 23, 2024
Summary: Pull Request resolved: facebook#46189 A lot of the style decorators we have (filters, box shadows, borders, etc) use a separate sub-CALayer to accomplish what they want. This becomes an issue if we are clipping the content to the bounds and if these decorators extend beyond the bounds of the view as they are typically unaffected by this clipping. The main things here are `box-shadow` and `outline`. However, this implementation will let us fix some issues w.r.t content rendering under borders. See later diffs for that. To fix this, if needed, we insert a `_containerView` to contain all of our subviews, and actually apply the clipping to. If this exists, our UIView will only have one subview, this one. But it may have multiple sublayers. NOTE: This diff does not actually redirect the clipping. It just inserts the subview to test if this breaks anything in and of itself. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D61414649
joevilches
force-pushed
the
export-D61414649
branch
from
dab820e to
14035ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61414649 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Aug 26, 2024
Summary: Pull Request resolved: facebook#46189 A lot of the style decorators we have (filters, box shadows, borders, etc) use a separate sub-CALayer to accomplish what they want. This becomes an issue if we are clipping the content to the bounds and if these decorators extend beyond the bounds of the view as they are typically unaffected by this clipping. The main things here are `box-shadow` and `outline`. However, this implementation will let us fix some issues w.r.t content rendering under borders. See later diffs for that. To fix this, if needed, we insert a `_containerView` to contain all of our subviews, and actually apply the clipping to. If this exists, our UIView will only have one subview, this one. But it may have multiple sublayers. NOTE: This diff does not actually redirect the clipping. It just inserts the subview to test if this breaks anything in and of itself. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D61414649
joevilches
force-pushed
the
export-D61414649
branch
from
14035ff to
38ae8e6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61414649 |
joevilches
force-pushed
the
export-D61414649
branch
from
38ae8e6 to
c61ec84
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: facebook#46189 A lot of the style decorators we have (filters, box shadows, borders, etc) use a separate sub-CALayer to accomplish what they want. This becomes an issue if we are clipping the content to the bounds and if these decorators extend beyond the bounds of the view as they are typically unaffected by this clipping. The main things here are `box-shadow` and `outline`. However, this implementation will let us fix some issues w.r.t content rendering under borders. See later diffs for that. To fix this, if needed, we insert a `_containerView` to contain all of our subviews, and actually apply the clipping to. If this exists, our UIView will only have one subview, this one. But it may have multiple sublayers. NOTE: This diff does not actually redirect the clipping. It just inserts the subview to test if this breaks anything in and of itself. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D61414649
Summary: Pull Request resolved: facebook#46189 A lot of the style decorators we have (filters, box shadows, borders, etc) use a separate sub-CALayer to accomplish what they want. This becomes an issue if we are clipping the content to the bounds and if these decorators extend beyond the bounds of the view as they are typically unaffected by this clipping. The main things here are `box-shadow` and `outline`. However, this implementation will let us fix some issues w.r.t content rendering under borders. See later diffs for that. To fix this, if needed, we insert a `_containerView` to contain all of our subviews, and actually apply the clipping to. If this exists, our UIView will only have one subview, this one. But it may have multiple sublayers. NOTE: This diff does not actually redirect the clipping. It just inserts the subview to test if this breaks anything in and of itself. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D61414649
|
This pull request was exported from Phabricator. Differential Revision: D61414649 |
joevilches
force-pushed
the
export-D61414649
branch
from
c61ec84 to
ed204d7
Compare
|
This pull request has been merged in 2176866. |
|
This pull request was successfully merged by @joevilches in 2176866 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A lot of the style decorators we have (filters, box shadows, borders, etc) use a separate sub-CALayer to accomplish what they want. This becomes an issue if we are clipping the content to the bounds and if these decorators extend beyond the bounds of the view as they are typically unaffected by this clipping. The main things here are
box-shadowandoutline. However, this implementation will let us fix some issues w.r.t content rendering under borders. See later diffs for that.To fix this, if needed, we insert a
_containerViewto contain all of our subviews, and actually apply the clipping to. If this exists, our UIView will only have one subview, this one. But it may have multiple sublayers.NOTE: This diff does not actually redirect the clipping. It just inserts the subview to test if this breaks anything in and of itself.
Changelog: [Internal]
Reviewed By: lenaic
Differential Revision: D61414649