Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Babel major version configurable #4437

Closed
idibidiart opened this issue Nov 30, 2015 · 3 comments
Closed

Make Babel major version configurable #4437

idibidiart opened this issue Nov 30, 2015 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@idibidiart
Copy link

Given the following issues popped up in Babel 6:

  1. Decorators cannot be used with RN 0.16..0-rc
  2. Can't export default class that extends base class

The first one being a serious issue as a lot of RN projects out there rely on @autoBind decorator (and having to replace with the ugliness that is .bind(this) everywhere is just too much to ask for given that a fix in is the works)

So, I'm wondering if it would be wise to allow the version of Babel used by RN to be configurable (maybe within the range of one major version number e.g. 5.x to 6.x)

@ide
Copy link
Contributor

ide commented Nov 30, 2015

I don't think the Babel version will be configurable because Facebook's infra has already moved on and it's like steering a big ship. Babel touches too many things for it to simply be a matter of changing the version number in package.json.

The decorators are a big issue. I'm going to work on it myself since the ecosystem needs something out there, but would appreciate help from someone who's written Babel plugins before.

@facebook-github-bot
Copy link
Contributor

Hey idibidiart, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

  • If this is a feature request or a bug that you would like to be fixed by the team, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
  • If you don't know how to do something or not sure whether some behavior is expected or a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
  • We welcome clear issues and PRs that are ready for in-depth discussion; thank you for your contributions!

@idibidiart
Copy link
Author

@sebmck @loganfsmyth FYI

That would be great @ide

Will be posting all future feature requests to ProductPains.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants