Remove dependency on PropsParserContext
#42616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
Base commit: 3869ae4 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 25, 2024
Summary: PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts. This change break the dependency by passing along only the elements that we actually need. ## Changelog [Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext Differential Revision: D52999204
cipolleschi
force-pushed
the
export-D52999204
branch
from
7b4b51c to
3e941ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 26, 2024
Summary: PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts. This change break the dependency by passing along only the elements that we actually need. ## Changelog [Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext Differential Revision: D52999204
cipolleschi
force-pushed
the
export-D52999204
branch
from
3e941ad to
8deab5c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 26, 2024
Summary: PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts. This change break the dependency by passing along only the elements that we actually need. ## Changelog [Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext Differential Revision: D52999204
cipolleschi
force-pushed
the
export-D52999204
branch
from
8deab5c to
b726213
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 26, 2024
Summary: PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts. This change break the dependency by passing along only the elements that we actually need. ## Changelog [Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext Differential Revision: D52999204
cipolleschi
force-pushed
the
export-D52999204
branch
from
b726213 to
14044a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
force-pushed
the
export-D52999204
branch
from
14044a1 to
8dfe5d5
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 29, 2024
Summary: PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts. This change break the dependency by passing along only the elements that we actually need. ## Changelog [Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext Reviewed By: sammy-SC Differential Revision: D52999204
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 29, 2024
Summary: PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts. This change break the dependency by passing along only the elements that we actually need. ## Changelog [Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext Reviewed By: sammy-SC Differential Revision: D52999204
cipolleschi
force-pushed
the
export-D52999204
branch
from
8dfe5d5 to
2f5683a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 29, 2024
Summary: PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts. This change break the dependency by passing along only the elements that we actually need. ## Changelog [Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext Reviewed By: sammy-SC Differential Revision: D52999204
cipolleschi
force-pushed
the
export-D52999204
branch
from
2f5683a to
0b91bf0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 29, 2024
Summary: PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts. This change break the dependency by passing along only the elements that we actually need. ## Changelog [Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext Reviewed By: sammy-SC Differential Revision: D52999204
cipolleschi
force-pushed
the
export-D52999204
branch
from
0b91bf0 to
4bd44fe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 29, 2024
Summary: PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts. This change break the dependency by passing along only the elements that we actually need. ## Changelog [Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext Reviewed By: sammy-SC Differential Revision: D52999204
cipolleschi
force-pushed
the
export-D52999204
branch
from
4bd44fe to
260dc3f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
Summary: PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts. This change break the dependency by passing along only the elements that we actually need. ## Changelog [Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext Reviewed By: sammy-SC Differential Revision: D52999204
cipolleschi
force-pushed
the
export-D52999204
branch
from
260dc3f to
bc40417
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
|
This pull request has been merged in 5bf5f4b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the
surfaceIdand thecontextContainer. We don't need to bring to graphics the whole dependencies of core due to these two parts.This change break the dependency by passing along only the elements that we actually need.
Changelog
[Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext
Differential Revision: D52999204