-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextInput's selectionColor doesn't style Android's selection handles #30283
Comments
i have the same problem with you. and i tried to config some android xml files and turn out not work at all. |
I also meet this problem. Do you know the solutions now? @adamsoutar |
I'm pretty sure this problem has been around for a year at least. Ideally the prop should work cross-platform. Worst-case the docs should be updated to reflect that this is an iOS-only prop... |
Work In Progress 🚧
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)
Drawable mSelectHandleLeft;
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)
Drawable mSelectHandleRight;
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)
Drawable mSelectHandleCenter; I just applied this gist solution and I was able to fix this issue. I'll prepare a pr 🙏 ☮️
|
Description
Using
selectionColor
on iOS styles the selection, as well as the 'handles' on either side of it:However, on Android these handles are green, which also happens to be the default
selectionColor
if you don't override it. I feel that these should go along with what iOS does (turn pink in this example).Another example (where it should also be pink):
React Native version:
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.
selectionColor
prop to somethingExpected Results
The selection drag handles should be coloured by
selectionColor
on Android.Snack, code example, screenshot, or link to a repository:
Snack
The text was updated successfully, but these errors were encountered: