Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controlled TextInput no longer works correctly #19348

Closed
christianlundberg opened this issue May 18, 2018 · 1 comment
Closed

Controlled TextInput no longer works correctly #19348

christianlundberg opened this issue May 18, 2018 · 1 comment
Labels
Component: TextInput Related to the TextInput component. Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Resolution: Locked This issue was locked by the bot.

Comments

@christianlundberg
Copy link

Controlled TextInput's value prop should be the source if truth, but that's no longer the case.

Environment

Environment:
OS: macOS High Sierra 10.13.4
Node: 8.11.1
Yarn: Not Found
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.3 Build version 9E145
Android Studio: 3.1 AI-173.4697961

Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: 0.55.4 => 0.55.4

Steps to Reproduce

Render a TextInput, and give it a hardcoded value which is never updated

<TextInput value="Hello world" />

Expected Behavior

No matter how much you type, the value should remain unchanged.

Actual Behavior

The value changes. This is clearly a regression because after downgrading to 0.53, it works as expected.
@react-native-bot react-native-bot added the Component: TextInput Related to the TextInput component. label May 18, 2018
@hramos hramos added the Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. label May 19, 2018
@vovkasm
Copy link
Contributor

vovkasm commented May 21, 2018

Duplicate of #18874

@hramos hramos closed this as completed Jun 15, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Jun 15, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: TextInput Related to the TextInput component. Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vovkasm @hramos @christianlundberg @react-native-bot