Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geolocation API doesn't fit specification #17232

Closed
EJohnF opened this issue Dec 15, 2017 · 2 comments
Closed

Geolocation API doesn't fit specification #17232

EJohnF opened this issue Dec 15, 2017 · 2 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@EJohnF
Copy link

EJohnF commented Dec 15, 2017

RN documentation says:

The Geolocation API extends the web spec: https://developer.mozilla.org/en-US/docs/Web/API/Geolocation

If open that site, we can find

PositionOptions.maximumAge Secure context
Is a positive long value indicating the maximum age in milliseconds of a possible cached position that is acceptable to return. If set to 0, it means that the device cannot use a cached position and must attempt to retrieve the real current position. If set to Infinity the device must return a cached position regardless of its age. Default: 0

So that default value is 0

While in actual RN implementation
android
ios

You can see that default value is INFINITY.

In conclusion: I think need to either edit RN docs and put an additional comment about that difference or change the implementation to fit Mozilla docs.

Thank you!

@react-native-bot
Copy link
Collaborator

@facebook-github-bot no-template

@facebook-github-bot
Copy link
Contributor

Hey @EJohnF, thanks for posting this! It looks like your issue is missing some required information. Can you please add all the details specified in the Issue Template? This is necessary for people to be able to understand and reproduce your issue. I am going to close this, but please feel free to open a new issue with the additional information provided. Thanks!

How to ContributeWhat to Expect from Maintainers

@facebook-github-bot facebook-github-bot added the Ran Commands One of our bots successfully processed a command. label Dec 15, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Dec 15, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Dec 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants