Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Bug] Memory grows over time in sample app #16600

Closed
kesha-antonov opened this issue Oct 30, 2017 · 16 comments
Closed

[Android][Bug] Memory grows over time in sample app #16600

kesha-antonov opened this issue Oct 30, 2017 · 16 comments
Labels
Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@kesha-antonov
Copy link
Contributor

kesha-antonov commented Oct 30, 2017

Hello!

I've noticed that memory grows over time with no reason. In my app I see significant growth. In sample app is lower. But still.
It grows over limit. And then starts again and never stops to grow.

What's the reason?

Here's video:

ezgif com-video-to-gif 1

Is this a bug report?

Yes.

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS High Sierra 10.13
Node: 6.11.3
Yarn: Not Found
npm: 5.4.2
Watchman: 4.9.0
Xcode: Xcode 9.0 Build version 9A235
Android Studio: 2.3 AI-162.3871768

Packages: (wanted => installed)
react: 16.0.0-beta.5 => 16.0.0-beta.5
react-native: 0.49.5 => 0.49.5

Steps to Reproduce

  1. Create sample RN app
  2. Open Android studio - Android monitor
  3. See memory usage grows over time

Expected Behavior

Not growing memory

Actual Behavior

Memory grows over time.

Reproducible Demo

No need. Just use sample app

@kesha-antonov
Copy link
Contributor Author

ezgif com-video-to-gif

@yinghang
Copy link

yinghang commented Nov 3, 2017

@kesha-antonov Can you try running 0.50.0-rc.2 and see if it still happens? I've been running the sample app (with constant but simple network calls) on 0.50.0-rc.2 for > 12 hours and my memory graph still looks pretty flat.

screen shot 2017-11-03 at 9 35 55 am

@yinghang
Copy link

yinghang commented Nov 3, 2017

Also, wondering if you're running the profiler with the debug build? If you are, chances are that the memory usage will keep growing.

@kesha-antonov
Copy link
Contributor Author

@yinghang Ok thanks! I will try latest master

@kesha-antonov
Copy link
Contributor Author

kesha-antonov commented Nov 3, 2017

Also, wondering if you're running the profiler with the debug build? If you are, chances are that the memory usage will keep growing.

I've tried both. Memory grows. In sample app slowly. In my production app faster

With recent master will try tomorrow

@kesha-antonov
Copy link
Contributor Author

@yinghang BTW your graph looks like a saw. It means memory constantly grows and garbage collected. You think it's okay? I don't have much experience with java so not sure.

@yinghang
Copy link

yinghang commented Nov 4, 2017

I think so, I think it's due to the API call that I'm making every 5 seconds.

@kesha-antonov
Copy link
Contributor Author

Maybe related #16732

@yinghang
Copy link

Are you using WebSockets in your app? If not I'm afraid that they're probably unrelated. Also, did you get to build your app with the release variant? App memory will grow continuously in debug mode.

@stale
Copy link

stale bot commented Jan 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 15, 2018
@kesha-antonov
Copy link
Contributor Author

It's active

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 15, 2018
@nachofregeiro
Copy link

Any update on this?

@hramos hramos added the Android label Mar 8, 2018
@react-native-bot react-native-bot added the Ran Commands One of our bots successfully processed a command. label Mar 18, 2018
@react-native-bot react-native-bot added Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. labels Mar 18, 2018
@stale
Copy link

stale bot commented Jun 17, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jun 17, 2018
@kesha-antonov
Copy link
Contributor Author

It's active

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Jun 17, 2018
@stale
Copy link

stale bot commented Sep 15, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 15, 2018
@stale
Copy link

stale bot commented Sep 22, 2018

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Sep 22, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Sep 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

6 participants