Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebView] WebView types missing #13662

Closed
Kingles opened this issue Apr 25, 2017 · 2 comments
Closed

[WebView] WebView types missing #13662

Kingles opened this issue Apr 25, 2017 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@Kingles
Copy link

Kingles commented Apr 25, 2017

Description

WebView has no proper flowtypes.

Reproduction Steps and Sample Code

Environment

  • react-native: 0.43.4
  • flow-bin: 0.40.0
  1. import WebView
  2. use it
  3. attempt to access props or exposed functions
  4. observe that props and exposed methods (injectJavaScript, for example) are not covered by flow.
// @flow
import React, {PureComponent} from 'react';
import {WebView, View, Button} from 'react-native';
import htmlTemplate from './template.html';

export default class TestComponent extends PureComponent {
  webview: ?WebView = null;

  handlePress = () => {
    const {webview} = this;
    if (webview) {
      const script = "alert('sup :3')";
      webview.injectJavaScript(script);
    }
  };
  render() {
    <View>
      <Button onPress={this.handlePress}>
        Press me!
      </Button>
      <WebView
        ref={(webview: WebView) => {
          this.webview = webview;
        }}
        source={htmlTemplate}
      />
    </View>;
  }
}

Solution

Add missing flowtypes to WebView.

Additional Information

  • React Native version: 0.43.4
  • Platform: both
  • Development Operating System: MacOS
  • Dev tools: N/A
@hramos hramos changed the title WebView types missing [WebView] WebView types missing May 31, 2017
@hramos
Copy link
Contributor

hramos commented May 31, 2017

Would you consider sending a PR to add these types?

@hramos
Copy link
Contributor

hramos commented Aug 16, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Aug 16, 2017
@hramos hramos closed this as completed Aug 16, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Aug 16, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants