You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
symptom:
supply shouldItemUpdate() and data=[1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 7, 8, 9, 10, 11, ...] to a FlatList with 3 columns
shouldItemUpdate() is called with incorrect data {index: 6, item: 9}
expect {index: 6, item:7} or {index: 8, item 9}
further investigation:
seems that in FlatList.js, _shouldItemUpdate() does not take numColumns into account when calling shouldItemUpdate()
Reproduction Steps and Sample Code
obverse the values received in shouldItemUpdate()
classAppClassextendsReact.Component{constructor(props){super(props)this.data=[1,2,3,4,5,6,7,8,9,10,11,12,7,8,9,10,11,];}shouldItemUpdate(props,nextProps){// some code}render(){return(<FlatList{...(this.modifiedProps)}data={this.data}numColumns={3}shouldItemUpdate={this.shouldItemUpdate}renderItem={this.renderItem}></FlatList>);}}
Solution
add *numColumns in _shouldItemUpdate function seems to have solved the problem
The text was updated successfully, but these errors were encountered:
hramos
changed the title
FlatList: shouldItemUpdate called with incorrect {item,index}
[FlatList] shouldItemUpdate called with incorrect {item,index}
Apr 25, 2017
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.
Description
symptom:
supply shouldItemUpdate() and data=[1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 7, 8, 9, 10, 11, ...] to a FlatList with 3 columns
shouldItemUpdate() is called with incorrect data {index: 6, item: 9}
expect {index: 6, item:7} or {index: 8, item 9}
further investigation:
seems that in FlatList.js, _shouldItemUpdate() does not take numColumns into account when calling shouldItemUpdate()
Reproduction Steps and Sample Code
obverse the values received in shouldItemUpdate()
Solution
add *numColumns in _shouldItemUpdate function seems to have solved the problem
Additional Information
The text was updated successfully, but these errors were encountered: