From f1aabc51646ac98e29df5a351b900b8799948283 Mon Sep 17 00:00:00 2001 From: Phillip Pan Date: Wed, 20 Oct 2021 15:40:37 -0700 Subject: [PATCH] remove unnecessary public methods on RCTFabricSurface Summary: Changelog: [Internal] `start` and `stop` are already part of `RCTSurfaceProtocol` which is a public protocol conformance, we don't need to add these to this header, it's just extra work for the compiler Reviewed By: RSNara Differential Revision: D31776005 fbshipit-source-id: d89ad4dbe35e1b67cfa750c6414c40f9b4fc7f24 --- React/Fabric/Surface/RCTFabricSurface.h | 30 ++++++++----------------- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/React/Fabric/Surface/RCTFabricSurface.h b/React/Fabric/Surface/RCTFabricSurface.h index 637970dce888ec..24e487108e3ddf 100644 --- a/React/Fabric/Surface/RCTFabricSurface.h +++ b/React/Fabric/Surface/RCTFabricSurface.h @@ -38,6 +38,15 @@ NS_ASSUME_NONNULL_BEGIN moduleName:(NSString *)moduleName initialProperties:(NSDictionary *)initialProperties; +#pragma mark - Surface presenter + +/** + * EXPERIMENTAL + * Reset's the Surface to it's initial stage. + * It uses the passed in surface presenter, and whatever else was passed in init. + */ +- (void)resetWithSurfacePresenter:(RCTSurfacePresenter *)surfacePresenter; + #pragma mark - Dealing with UIView representation, the Main thread only access /** @@ -54,27 +63,6 @@ NS_ASSUME_NONNULL_BEGIN */ - (RCTSurfaceView *)view; -#pragma mark - Start & Stop - -/** - * Starts or stops the Surface. - * A Surface object can be stopped and then restarted. - * The starting process includes initializing all underlying React Native - * infrastructure and running React app. - * Surface stops itself on deallocation automatically. - * Returns YES in case of success. Returns NO if the Surface is already - * started or stopped. - */ -- (BOOL)start; -- (BOOL)stop; - -/** - * EXPERIMENTAL - * Reset's the Surface to it's initial stage. - * It uses the passed in surface presenter, and whatever else was passed in init. - */ -- (void)resetWithSurfacePresenter:(RCTSurfacePresenter *)surfacePresenter; - #pragma mark - Layout: Setting the size constrains /**