From bb6bbfc261334fd98f30b6933c426ac1196b8804 Mon Sep 17 00:00:00 2001
From: Samuel Susla <samuelsusla@meta.com>
Date: Fri, 10 Jan 2025 03:23:11 -0800
Subject: [PATCH] remove folly::tryTo (#48557)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/48557

changelog: [internal]

delete use of folly::tryTo from react native.

Reviewed By: christophpurrer

Differential Revision: D67942789

fbshipit-source-id: 976caa12b6ff6063041be3259aa8ebd642ca3ca0
---
 .../renderer/components/view/conversions.h    | 46 +++++++++++++------
 1 file changed, 33 insertions(+), 13 deletions(-)

diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/conversions.h b/packages/react-native/ReactCommon/react/renderer/components/view/conversions.h
index ef4202ce9580b8..c782e566ca2200 100644
--- a/packages/react-native/ReactCommon/react/renderer/components/view/conversions.h
+++ b/packages/react-native/ReactCommon/react/renderer/components/view/conversions.h
@@ -31,6 +31,7 @@
 #include <algorithm>
 #include <cmath>
 #include <optional>
+#include <string>
 #include <unordered_map>
 
 namespace facebook::react {
@@ -64,6 +65,25 @@ inline float yogaFloatFromFloat(Float value) {
   return (float)value;
 }
 
+/*
+ * Converts string to float only if the entire string is valid float.
+ */
+inline std::optional<float> stringToFloat(const std::string& string) {
+  try {
+    size_t pos = 0;
+    auto result = std::stof(string, &pos);
+    // Check if entire string was valid
+    if (pos == string.length()) {
+      return result;
+    }
+  } catch (...) {
+    // Ignore, caller falls back to default value.
+    return std::nullopt;
+  }
+
+  return std::nullopt;
+}
+
 /*
  * `yoga::FloatOptional` <-> React Native's `Float`
  *
@@ -467,15 +487,15 @@ inline void fromRawValue(
       return;
     } else {
       if (stringValue.back() == '%') {
-        auto tryValue = folly::tryTo<float>(
-            std::string_view(stringValue).substr(0, stringValue.length() - 1));
-        if (tryValue.hasValue()) {
+        auto tryValue =
+            stringToFloat(stringValue.substr(0, stringValue.length() - 1));
+        if (tryValue.has_value()) {
           result = yoga::StyleSizeLength::percent(tryValue.value());
           return;
         }
       } else {
-        auto tryValue = folly::tryTo<float>(stringValue);
-        if (tryValue.hasValue()) {
+        auto tryValue = stringToFloat(stringValue);
+        if (tryValue.has_value()) {
           result = yoga::StyleSizeLength::points(tryValue.value());
           return;
         }
@@ -499,15 +519,15 @@ inline void fromRawValue(
       return;
     } else {
       if (stringValue.back() == '%') {
-        auto tryValue = folly::tryTo<float>(
-            std::string_view(stringValue).substr(0, stringValue.length() - 1));
-        if (tryValue.hasValue()) {
+        auto tryValue =
+            stringToFloat(stringValue.substr(0, stringValue.length() - 1));
+        if (tryValue.has_value()) {
           result = yoga::StyleLength::percent(tryValue.value());
           return;
         }
       } else {
-        auto tryValue = folly::tryTo<float>(stringValue);
-        if (tryValue.hasValue()) {
+        auto tryValue = stringToFloat(stringValue);
+        if (tryValue.has_value()) {
           result = yoga::StyleLength::points(tryValue.value());
           return;
         }
@@ -573,9 +593,9 @@ inline void fromRawValue(
     const auto stringValue = (std::string)value;
 
     if (stringValue.back() == '%') {
-      auto tryValue = folly::tryTo<float>(
-          std::string_view(stringValue).substr(0, stringValue.length() - 1));
-      if (tryValue.hasValue()) {
+      auto tryValue =
+          stringToFloat(stringValue.substr(0, stringValue.length() - 1));
+      if (tryValue.has_value()) {
         valueUnit = ValueUnit(tryValue.value(), UnitType::Percent);
       }
     }