Skip to content

Commit

Permalink
workaround framework build error because c++ header should not be exp…
Browse files Browse the repository at this point in the history
…orted
  • Loading branch information
Kudo committed Mar 11, 2022
1 parent 4003274 commit 7a0398c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions React/CoreModules/RCTExceptionsManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#import <Foundation/Foundation.h>
#import <React/RCTBridgeModule.h>
#import <string>

NS_ASSUME_NONNULL_BEGIN

Expand Down Expand Up @@ -37,7 +36,7 @@ NS_ASSUME_NONNULL_BEGIN
- (void)reportFatalException:(nullable NSString *)message
stack:(nullable NSArray<NSDictionary *> *)stack
exceptionId:(double)exceptionId;
- (void)reportEarlyJsException:(std::string)errorMap;
- (void)reportEarlyJsException:(nullable NSString *)errorMap;

@property (nonatomic, weak) id<RCTExceptionsManagerDelegate> delegate;

Expand Down
4 changes: 2 additions & 2 deletions React/CoreModules/RCTExceptionsManager.mm
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,9 @@ - (void)reportFatal:(NSString *)message stack:(NSArray<NSDictionary *> *)stack e
}
}

- (void)reportEarlyJsException:(std::string)errorMap
- (void)reportEarlyJsException:(NSString *)errorMap
{
NSString *errprStr = [NSString stringWithUTF8String:errorMap.c_str()];
NSString *errprStr = errorMap;
NSData *jsonData = [errprStr dataUsingEncoding:NSUTF8StringEncoding];
NSError *jsonError;
NSDictionary *dict = [NSJSONSerialization JSONObjectWithData:jsonData
Expand Down

0 comments on commit 7a0398c

Please sign in to comment.