-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Align android image style / source logic with ios (#34655)
Summary: This aligns the logic of setting style (width / height) and source of Android with iOS. iOS handles nullish uris with set width and heigth by passing them through. Android did not. ## Changelog [Android] [Fixed] - Align android image style / source logic with ios Pull Request resolved: #34655 Test Plan: ``` <Image source={{width: 100, height: 100}} /> ``` Before this Patch: * iOS: Renders a blank image with 100x100 * Android: Renders a blank image with 0x0 After this Patch: * iOS: Renders a blank image with 100x100 * Android: Renders a blank image with 100x100 Reviewed By: sammy-SC Differential Revision: D39423391 Pulled By: cipolleschi fbshipit-source-id: 997c06dea42e9b69fda12b678a1b82ad8319537f
- Loading branch information
1 parent
0cae495
commit 6bdcb49
Showing
3 changed files
with
16 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters