From 5da7089e35b34cb3964ee485ddd52892917a7bbc Mon Sep 17 00:00:00 2001 From: Arushi Kesarwani Date: Wed, 27 Nov 2024 17:26:19 -0800 Subject: [PATCH] NIT: Updating docstring for DefaultReactHost for missing arguments (#47992) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47992 TSIA Changelog: [Internal] Reviewed By: shwanton Differential Revision: D66552119 fbshipit-source-id: 6dcd461fcea1444a58db4f98316bf8878ae98781 --- .../java/com/facebook/react/defaults/DefaultReactHost.kt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactHost.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactHost.kt index 7644ecc77b3e27..9dab78f83a4fc0 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactHost.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactHost.kt @@ -43,6 +43,8 @@ public object DefaultReactHost { * `index.` * @param jsBundleAssetPath the path to the JS bundle relative to the assets directory. Will be * composed in a `asset://...` URL + * @param jsBundleFilePath the path to the JS bundle on the filesystem. Will be composed in a + * `file://...` URL * @param isHermesEnabled whether to use Hermes as the JS engine, default to true. * @param useDevSupport whether to enable dev support, default to ReactBuildConfig.DEBUG. * @param cxxReactPackageProviders a list of cxxreactpackage providers (to register c++ turbo @@ -84,12 +86,15 @@ public object DefaultReactHost { * `index.` * @param jsBundleAssetPath the path to the JS bundle relative to the assets directory. Will be * composed in a `asset://...` URL + * @param jsBundleFilePath the path to the JS bundle on the filesystem. Will be composed in a + * `file://...` URL * @param isHermesEnabled whether to use Hermes as the JS engine, default to true. * @param useDevSupport whether to enable dev support, default to ReactBuildConfig.DEBUG. * @param cxxReactPackageProviders a list of cxxreactpackage providers (to register c++ turbo * modules) * @param exceptionHandler Callback that can be used by React Native host applications to react to * exceptions thrown by the internals of React Native. + * @param bindingsInstaller that can be used for installing bindings. * * TODO(T186951312): Should this be @UnstableReactNativeAPI? */