From 36a64dc2bd9de52841a52c549f35b944020bdb53 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Mon, 20 Feb 2023 11:50:10 -0800 Subject: [PATCH] Move the RCTAppsetuUtils to AppDelegate Summary: This change solve a Circular Dependency where - `React-Core` depends on `ReactCommon` because `RCTAppSetupUtils.h` (in Core) imports the `RCTTurboModuleManager` (from ReactCommon) - `RCTTurboModuleManager` in `ReactCommon` depends on `React-Core` because it imports several classes from it (e.g. the `RCTBridge` class) ## Changelog: [iOS][Breaking] - Moved the RCTAppSetupUtils to the AppDelegate library to break a dependency cycle Reviewed By: sammy-SC, dmytrorykun Differential Revision: D43089183 fbshipit-source-id: d7fc36a50811962caf7cff77bb45d42b8cdd4575 --- Libraries/AppDelegate/RCTAppDelegate.mm | 2 +- {React/AppSetup => Libraries/AppDelegate}/RCTAppSetupUtils.h | 0 {React/AppSetup => Libraries/AppDelegate}/RCTAppSetupUtils.mm | 0 3 files changed, 1 insertion(+), 1 deletion(-) rename {React/AppSetup => Libraries/AppDelegate}/RCTAppSetupUtils.h (100%) rename {React/AppSetup => Libraries/AppDelegate}/RCTAppSetupUtils.mm (100%) diff --git a/Libraries/AppDelegate/RCTAppDelegate.mm b/Libraries/AppDelegate/RCTAppDelegate.mm index ff822723accdcf..5b48b26545a673 100644 --- a/Libraries/AppDelegate/RCTAppDelegate.mm +++ b/Libraries/AppDelegate/RCTAppDelegate.mm @@ -6,8 +6,8 @@ */ #import "RCTAppDelegate.h" -#import #import +#import "RCTAppSetupUtils.h" #if RCT_NEW_ARCH_ENABLED #import diff --git a/React/AppSetup/RCTAppSetupUtils.h b/Libraries/AppDelegate/RCTAppSetupUtils.h similarity index 100% rename from React/AppSetup/RCTAppSetupUtils.h rename to Libraries/AppDelegate/RCTAppSetupUtils.h diff --git a/React/AppSetup/RCTAppSetupUtils.mm b/Libraries/AppDelegate/RCTAppSetupUtils.mm similarity index 100% rename from React/AppSetup/RCTAppSetupUtils.mm rename to Libraries/AppDelegate/RCTAppSetupUtils.mm