From 0f8a83eb49221fa98057cb2ef57b44491e9ec08c Mon Sep 17 00:00:00 2001 From: Gabriel Donadel Date: Wed, 1 Nov 2023 13:43:34 -0700 Subject: [PATCH] Fix ios pod post_install logic for detecting if fabric is enabled (#41284) Summary: There is a problem in the way that we check if Fabric is enabled inside `react_native_post_install`. https://github.com/facebook/react-native/blob/899e7cdb55197fc17a96a93af4f8bcc7519553c2/packages/react-native/scripts/react_native_pods.rb#L239 We're determining if fabric is enabled by checking if the `React-Fabric pod `is present, but since we always call `setup_fabric!(:react_native_path => prefix)` (https://github.com/facebook/react-native/pull/39057) inside `use_react_native` the `React-Fabric` pod is always present causing the `-DRN_FABRIC_ENABLED` flag to always be added to `project.pbxproj` even if the new arch is disabled. ## Changelog: [IOS] [FIXED] - Fix ios pod post_install logic for detecting if fabric is enabled Pull Request resolved: https://github.com/facebook/react-native/pull/41284 Test Plan: Run `use_react_native!(fabric => false)` should not add the `-DRN_FABRIC_ENABLED` flag to `project.pbxproj` Reviewed By: fkgozali Differential Revision: D50896487 Pulled By: cipolleschi fbshipit-source-id: 78154407ce52b09fd3a317b7dc64bd4bba56363e --- packages/react-native/scripts/react_native_pods.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/scripts/react_native_pods.rb b/packages/react-native/scripts/react_native_pods.rb index 4a37aefad7d67b..96e878eaa0b452 100644 --- a/packages/react-native/scripts/react_native_pods.rb +++ b/packages/react-native/scripts/react_native_pods.rb @@ -236,7 +236,7 @@ def react_native_post_install( ReactNativePodsUtils.apply_mac_catalyst_patches(installer) if mac_catalyst_enabled - fabric_enabled = ReactNativePodsUtils.has_pod(installer, 'React-Fabric') + fabric_enabled = ENV['RCT_FABRIC_ENABLED'] == '1' hermes_enabled = ReactNativePodsUtils.has_pod(installer, "React-hermes") if hermes_enabled