Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update in-app dev menu instructions, consistently name as "Dev Menu" #3692

Merged
merged 1 commit into from
Apr 20, 2023
Merged

[docs] Update in-app dev menu instructions, consistently name as "Dev Menu" #3692

merged 1 commit into from
Apr 20, 2023

Conversation

huntie
Copy link
Member

@huntie huntie commented Apr 19, 2023 •
edited
Loading

Summary

Context

Changes

  • Adds a new visual for the Dev Menu and simplifies instructions.
  • Adds "Dev Menu" to the glossary.
  • Renames all existing references to "[in-app] [dev|developer|debug] menu" to "Dev Menu".

Test Plan

  • See deploy preview.
Before After
image image

@netlify
Copy link

netlify bot commented Apr 19, 2023

✅ Deploy Preview for react-native ready!

Name Link
🔨 Latest commit f156806
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/64401e1645f1cf0008878caa
😎 Deploy Preview https://deploy-preview-3692--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

This was referenced Apr 19, 2023
Merged
Closed
huntie added a commit to huntie/react-native that referenced this pull request Apr 19, 2023
@huntie @facebook-github-bot
Rename "Debug Menu" title to "Dev Menu" on iOS
9fd9baa 
Summary:
We are (following a quick internal RFC) looking to standardise the term "[in-app] [Developer|Debug] menu" to "Dev Menu" in the React Native Debugging docs (and all docs references). (Indeed, the prevalent existing use in docs was already "Developer menu".) This PR aligns naming in the `RCTDevMenu` component on iOS.

See also facebook/react-native-website#3692.

Changelog:
[iOS][Changed] - Rename "Debug Menu" title to "Dev Menu"

Differential Revision: D44872456

fbshipit-source-id: 20eb1bbaff1b13be4090fda681d47557884ebd61
@huntie huntie marked this pull request as ready for review April 19, 2023 17:17
cortinico
cortinico approved these changes Apr 20, 2023
View reviewed changes
docs/debugging.md Show resolved Hide resolved
@huntie huntie merged commit 5fb9133 into facebook:main Apr 20, 2023
@huntie huntie deleted the debugging-guide-updates branch April 20, 2023 12:25
huntie added a commit to huntie/react-native that referenced this pull request Apr 20, 2023
@huntie @facebook-github-bot
Rename "Debug Menu" title to "Dev Menu" on iOS (facebook#36981)
179afe6 
Summary:
Pull Request resolved: facebook#36981

We are (following a quick internal RFC) looking to standardise the term "[in-app] [Developer|Debug] menu" to "Dev Menu" in the React Native Debugging docs (and all docs references). (Indeed, the prevalent existing use in docs was already "Developer menu".) This PR aligns naming in the `RCTDevMenu` component on iOS.

See also facebook/react-native-website#3692.

Changelog:
[iOS][Changed] - Rename "Debug Menu" title to "Dev Menu"

Reviewed By: christophpurrer

Differential Revision: D44872456

fbshipit-source-id: 3f7cd2218860717e024890884e7cbc241b70abf5
huntie added a commit to huntie/react-native that referenced this pull request Apr 20, 2023
@huntie @facebook-github-bot
Rename "Debug Menu" title to "Dev Menu" on iOS (facebook#36981)
3e55613 
Summary:
Pull Request resolved: facebook#36981

We are (following a quick internal RFC) looking to standardise the term "[in-app] [Developer|Debug] menu" to "Dev Menu" in the React Native Debugging docs (and all docs references). (Indeed, the prevalent existing use in docs was already "Developer menu".) This PR aligns naming in the `RCTDevMenu` component on iOS.

See also facebook/react-native-website#3692.

Changelog:
[iOS][Changed] - Rename "Debug Menu" title to "Dev Menu"

Reviewed By: christophpurrer

Differential Revision: D44872456

fbshipit-source-id: b1a92d462df3eb44ebc7d43dcc39264c67e4fc3a
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Apr 20, 2023
@huntie @facebook-github-bot
Rename "Debug Menu" title to "Dev Menu" on iOS (#36981)
6971540 
Summary:
Pull Request resolved: #36981

We are (following a quick internal RFC) looking to standardise the term "[in-app] [Developer|Debug] menu" to "Dev Menu" in the React Native Debugging docs (and all docs references). (Indeed, the prevalent existing use in docs was already "Developer menu".) This PR aligns naming in the `RCTDevMenu` component on iOS.

See also facebook/react-native-website#3692.

Changelog:
[iOS][Changed] - Rename "Debug Menu" title to "Dev Menu"

Reviewed By: christophpurrer

Differential Revision: D44872456

fbshipit-source-id: c222bb2c551a4f434a1dc0efbb8d4f75c785aa11
kelset pushed a commit to facebook/react-native that referenced this pull request May 3, 2023
@huntie @kelset
Rename "Debug Menu" title to "Dev Menu" on iOS (#36981)
d7af544 
Summary:
Pull Request resolved: #36981

We are (following a quick internal RFC) looking to standardise the term "[in-app] [Developer|Debug] menu" to "Dev Menu" in the React Native Debugging docs (and all docs references). (Indeed, the prevalent existing use in docs was already "Developer menu".) This PR aligns naming in the `RCTDevMenu` component on iOS.

See also facebook/react-native-website#3692.

Changelog:
[iOS][Changed] - Rename "Debug Menu" title to "Dev Menu"

Reviewed By: christophpurrer

Differential Revision: D44872456

fbshipit-source-id: c222bb2c551a4f434a1dc0efbb8d4f75c785aa11
jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
@huntie @jeongshin
Rename "Debug Menu" title to "Dev Menu" on iOS (facebook#36981)
4c7c96f 
Summary:
Pull Request resolved: facebook#36981

We are (following a quick internal RFC) looking to standardise the term "[in-app] [Developer|Debug] menu" to "Dev Menu" in the React Native Debugging docs (and all docs references). (Indeed, the prevalent existing use in docs was already "Developer menu".) This PR aligns naming in the `RCTDevMenu` component on iOS.

See also facebook/react-native-website#3692.

Changelog:
[iOS][Changed] - Rename "Debug Menu" title to "Dev Menu"

Reviewed By: christophpurrer

Differential Revision: D44872456

fbshipit-source-id: c222bb2c551a4f434a1dc0efbb8d4f75c785aa11
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@huntie @OlimpiaZurek
Rename "Debug Menu" title to "Dev Menu" on iOS (facebook#36981)
b489101 
Summary:
Pull Request resolved: facebook#36981

We are (following a quick internal RFC) looking to standardise the term "[in-app] [Developer|Debug] menu" to "Dev Menu" in the React Native Debugging docs (and all docs references). (Indeed, the prevalent existing use in docs was already "Developer menu".) This PR aligns naming in the `RCTDevMenu` component on iOS.

See also facebook/react-native-website#3692.

Changelog:
[iOS][Changed] - Rename "Debug Menu" title to "Dev Menu"

Reviewed By: christophpurrer

Differential Revision: D44872456

fbshipit-source-id: c222bb2c551a4f434a1dc0efbb8d4f75c785aa11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
CLA Signed p: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huntie @cortinico @facebook-github-bot