Possible fix for react-devtools-core break

Some time ago, when updating Babel and Webpack (PR #1235) the 'libraryTarget' Webpack setting was accidentally changed from 'umd' to default (global) which, I believe, caused the subsequent 3.5.0 react-devtools/react-devtools-core releases to break. This change restores the 'libraryTarget' value to 'umd' for the backend.' git status
facebook · Jan 4, 2019 · bcf6b1a · bcf6b1a
1 parent b2c1ae6
commit bcf6b1a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/packages/react-devtools-core/package.json b/packages/react-devtools-core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-devtools-core",
-  "version": "3.5.0",
+  "version": "3.5.1",
   "description": "Use react-devtools outside of the browser",
   "main": "./build/backend.js",
   "repository": {

diff --git a/packages/react-devtools-core/webpack.backend.js b/packages/react-devtools-core/webpack.backend.js
@@ -24,6 +24,8 @@ module.exports = {
   output: {
     path: __dirname + '/build',
     filename: '[name].js',
+    library: '[name]',
+    libraryTarget: 'umd',
   },
   plugins: __DEV__ ? [] : [
     // Ensure we get production React

diff --git a/packages/react-devtools/package.json b/packages/react-devtools/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-devtools",
-  "version": "3.5.0",
+  "version": "3.5.1",
   "description": "Use react-devtools outside of the browser",
   "repository": {
     "url": "https://github.com/facebook/react-devtools.git",
@@ -26,7 +26,7 @@
     "electron": "^1.8.7",
     "ip": "^1.1.4",
     "minimist": "^1.2.0",
-    "react-devtools-core": "^3.5.0",
+    "react-devtools-core": "^3.5.1",
     "update-notifier": "^2.1.0"
   }
 }