Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Authentication #531

Open
SteveSelva opened this issue Nov 7, 2024 · 3 comments
Open

Proxy Authentication #531

SteveSelva opened this issue Nov 7, 2024 · 3 comments

Comments

@SteveSelva
Copy link
Contributor

SteveSelva commented Nov 7, 2024

When the HTTP1xCodec generates HTTP CONNECT request and waits for a response.

And when it receives status code as 200, there should not be any body according to the protocol and its working fine.

But when the server responds with 407 Proxy Authentication Required, it may send a body with it. In this case, the codec is failing and throwing an error.

Instead of directly denying the body for HTTP CONNECT request, it can be done relative to the status code from response.

Can you modify the codec accordingly.

@afrind
Copy link
Contributor

afrind commented Nov 7, 2024

Would you like to put up a PR we can review? It might take some time before we can work on this modification.

@SteveSelva
Copy link
Contributor Author

Yeah sure, let me raise a PR.

@SteveSelva
Copy link
Contributor Author

Raised a PR : #532

Kindly review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants