Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should I use prophet cross validation results to compare 2 models ? #2606

Open
amrita2496 opened this issue Aug 4, 2024 · 0 comments
Open

Comments

@amrita2496
Copy link

According to this #1409 issue, we have to do model.fit() on entire time series before cross validation so that the attributes are all fixed for all CV runs. I get that but would it not slightly defeat the purpose of cross validation while hyperparameter tuning. I am comparing two models on the basis of their CV results. One model is having a very high changepoint_prior_scale around 0.95 and another one is lower around 0.5. Other things are mostly the same. I am guessing since the models are first fit on entire data including CV data and first one is more flexible for trend (potentially overfitted?) it would probably give better cv results than the other. It does not make the first model better for unseen data.

I was trying to follow recommended ranges from the documentation in which it is written for changepoint_prior_scale a range of [0.001, 0.5] would likely be about right. Link:
https://facebook.github.io/prophet/docs/diagnostics.html#hyperparameter-tuning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant