Resolves transformerPath before attempting to read contents. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration paths are now supposed to be relative to allow them to be shared on different paths/machines. This change makes sure that the new relative transformerPath is require.resolved before being passed to fs.readFileSync.
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 144 144
Lines 4556 4556
Branches 712 712
=======================================
Hits 3904 3904
Misses 582 582
Partials 70 70
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
rafeca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Yay! thanks! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Configuration paths are now supposed to be relative to allow them to be shared
on different paths/machines. This change makes sure that the new relative
transformerPath is require.resolved before being passed to fs.readFileSync.
Test plan
I edited node_modules directly in metro-sample-app to ensure that the fix got
me passed the unable to resolve error.