Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for disappear transitions #743

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix support for disappear transitions #743

wants to merge 2 commits into from

Commits on Dec 22, 2020

  1. Fix support for disappear transitions 

    The current setupTransitions() implementation never looks at any
transitions defined on the previous LayoutState when creating
AnimationBindings. This can be an issue for disappear transitions
because the new LayoutState will no longer contain any disappearing
items.

This change adds logic in the TransitionManager to first create
AnimationBindings for the previous LayoutState, then create
AnimationBindings for the new LayoutState and finally merge the two.
    @chggr
    chggr committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    bf491ed View commit details
    Browse the repository at this point in the history

  2. Add null check when the currentTransitions is null 

    A null check is added to the TransitionManager to cover the case where
the current LayoutState does not contain any transitions.
    @chggr
    chggr committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    19cef73 View commit details
    Browse the repository at this point in the history