Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] changed react-testing-library package name to @testing-library/react #8753

Merged
merged 7 commits into from
Jul 27, 2019

Conversation

jdelucaa
Copy link
Contributor

@jdelucaa jdelucaa commented Jul 26, 2019

Updated react-testing-library package name to @testing-library/react in docs.

Summary

react-testing-library package has been moved (testing-library/dom-testing-library#260) and for new versions @testing-library/react should be installed instead of react-testing-library.

Please let me know if you think it is necessary to change versioned docs as well.

Test plan

I installed react-testing-library in my local project and got the following message:

npm WARN deprecated [email protected]: � react-testing-library has moved to @testing-library/react. Please uninstall react-testing-library and install @
testing-library/react instead, or use an older version of react-testing-library. Learn more about this change here: testing-library/dom-testing-library#260 Thanks! :)

Besides that, in this PR only documentation has been updated, no code breaking changes.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Jul 26, 2019

This will fail on node 6. Can you update the circle ci config to delete it on node 6 similar to the react native example?

(Ignore the circle failure on ci)

@SimenB
Copy link
Member

SimenB commented Jul 26, 2019

Oh, these are just doc changes 😅 Could you update https://github.com/facebook/jest/tree/master/examples/react-testing-library as well? You run the example locally by doing yarn && yarn jest react-testing-library

And yes, please update the versioned docs 🙂

@jdelucaa
Copy link
Contributor Author

@SimenB yes, just noticed the imports would need to be updated as well.. 😅
I'll do it.

examples/react-testing-library/package.json Outdated Show resolved Hide resolved
@SimenB SimenB merged commit 8902dbe into jestjs:master Jul 27, 2019
@SimenB
Copy link
Member

SimenB commented Jul 27, 2019

Thank you!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants