expect: Throw matcher error when received cannot be jasmine spy

[pedrottimark]

Summary

Throw matcher error from *Return* matchers if received is a spy function, instead of TypeError: received.getMockName is not a function

• Change isSpy function to test for both all and count methods
• Rename ensureMock as ensureMockOrSpy for *Call* matchers
• Add ensureMock function for *Return* matchers

EDIT: Jasmine spy functions do not provide information about return values

Test plan

• Defined createSpy in test file to return a mock of a spy function, because jasmine.createSpy is not defined when jest-circus is the test runner
• Added 10 passing positive and negative *Called* assertions with spy functions
• Replaced 4 failing positive and negative *Called* assertions with spy functions
• Updated 8 and removed 2 snapshots of matcher errors for *Return* assertions with ordinary function
• Added 4 snapshots of matcher errors for *Return* assertions with spy functions

[jeysal]

Jasmine spy functions do not provide information about return values

Ahh, that made clear why we're doing this 😄 LGTM

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.