Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Node 6 support #8455

Merged
merged 8 commits into from
Aug 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,6 @@ jobs:
- store_test_results:
path: reports/junit

test-node-6:
SimenB marked this conversation as resolved.
Show resolved Hide resolved
working_directory: ~/jest
docker:
- image: circleci/node:6
steps:
- checkout
- restore-cache: *restore-cache
- run: *install
- save-cache: *save-cache
- run:
# react-native and react-testing-library do not work with node 6
command: rm -rf examples/react-native examples/react-testing-library && yarn test-ci-partial
- store_test_results:
path: reports/junit

test-node-8:
working_directory: ~/jest
docker:
Expand Down Expand Up @@ -133,7 +118,6 @@ workflows:
build-and-deploy:
jobs:
- lint-and-typecheck
- test-node-6
- test-node-8
- test-node-10
- test-jest-circus
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

### Chore & Maintenance

- `[*]` [**BREAKING**] Drop support for Node 6 ([#8455](https://github.com/facebook/jest/pull/8455))
- `[docs]` Fix broken link pointing to legacy JS file in "Snapshot Testing".

### Performance
Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ module.exports = {
'@babel/preset-env',
{
shippedProposals: true,
targets: {node: 6},
targets: {node: 8},
},
],
],
Expand Down
4 changes: 0 additions & 4 deletions e2e/__tests__/__snapshots__/failures.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -774,10 +774,6 @@ FAIL __tests__/assertionError.test.js
82 |

at Object.equal (__tests__/assertionError.test.js:80:10)
at asyncGeneratorStep (__tests__/assertionError.test.js:10:103)
at _next (__tests__/assertionError.test.js:12:194)
at __tests__/assertionError.test.js:12:364
at Object.<anonymous> (__tests__/assertionError.test.js:12:97)
`;

exports[`works with snapshot failures 1`] = `
Expand Down
2 changes: 1 addition & 1 deletion e2e/__tests__/__snapshots__/moduleNameMapper.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ FAIL __tests__/index.js
12 | module.exports = () => 'test';
13 |

at createNoMappedModuleFoundError (../../packages/jest-resolve/build/index.js:493:17)
at createNoMappedModuleFoundError (../../packages/jest-resolve/build/index.js:468:17)
at Object.require (index.js:10:1)
`;
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,6 @@
"logo": "https://opencollective.com/jest/logo.txt"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
SimenB marked this conversation as resolved.
Show resolved Hide resolved
}
}
2 changes: 1 addition & 1 deletion packages/babel-jest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@babel/core": "^7.0.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-jest-hoist/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"directory": "packages/babel-plugin-jest-hoist"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"license": "MIT",
"main": "build/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-preset-jest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@babel/core": "^7.0.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/diff-sequences/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"diff"
],
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"main": "build/index.js",
"types": "build/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-fb-strict/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"eslint-plugin-react": "^7.1.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/expect/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"immutable": "^4.0.0-rc.12"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-changed-files/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@types/execa": "^0.9.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-circus/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"jest-runtime": "^24.9.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"jest": "./bin/jest.js"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@types/micromatch": "^3.1.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-console/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@types/slash": "^2.0.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@types/strip-ansi": "^3.0.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-diff/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"strip-ansi": "^5.0.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-docblock/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@types/detect-newline": "^2.1.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-each/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"pretty-format": "^24.9.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-environment-jsdom/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@types/jsdom": "^11.12.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-environment-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"jest-util": "^24.9.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-environment/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"jest-mock": "^24.9.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-fake-timers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"jest-mock": "^24.9.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-get-type/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"directory": "packages/jest-get-type"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"license": "MIT",
"main": "build/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-haste-map/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"fsevents": "^1.2.7"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-jasmine2/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@types/babel__traverse": "^7.0.4"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-leak-detector/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"weak": "^1.0.1"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-matcher-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"directory": "packages/jest-matcher-utils"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"license": "MIT",
"main": "build/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-message-util/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"directory": "packages/jest-message-util"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"license": "MIT",
"main": "build/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-mock/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"directory": "packages/jest-mock"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"dependencies": {
"@jest/types": "^24.9.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-phabricator/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@jest/test-result": "^24.9.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"license": "MIT",
"main": "build/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-regex-util/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"directory": "packages/jest-regex-util"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"license": "MIT",
"main": "build/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-repl/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"jest-repl": "./bin/jest-repl.js"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-reporters/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"strip-ansi": "^5.0.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-resolve-dependencies/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"jest-runtime": "^24.9.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-resolve/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"jest-haste-map": "^24.9.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-runner/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@types/source-map-support": "^0.5.0"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-runtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"jest-runtime": "./bin/jest-runtime.js"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-serializer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"directory": "packages/jest-serializer"
},
"engines": {
"node": ">= 6"
"node": ">= 8"
},
"license": "MIT",
"main": "build/index.js",
Expand Down
Loading