Remove monorepo-internal peer dependencies (temporarily)

[Hoishin]

Summary

Resolves #8107

Please see the issue for the motivation.

Moved peerDependencies that are served inside the monorepo to dependencies.

Test plan

N/A

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[Hoishin]

I have signed up the CLA before submitting this PR. Need some time to get updated?

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[SimenB]

Those are not dependencies, instances of the classes are injected. The real solution is to add the peer deps to every dependency between where they are used together. that should resolve the warning

[codecov-io]

Codecov Report

Merging #8215 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8215   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files         265      265           
  Lines       10534    10534           
  Branches     2557     2556    -1     
=======================================
  Hits         6564     6564           
  Misses       3387     3387           
  Partials      583      583

Impacted Files	Coverage Δ
packages/jest-resolve/src/index.ts	40.44% <ø> (ø)	⬆️
packages/jest-snapshot/src/index.ts	28.57% <ø> (ø)	⬆️
packages/jest-resolve-dependencies/src/index.ts	89.79% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ce3f3...e69dcf9. Read the comment docs.

[Hoishin]

@SimenB In that case, would it be another possible solution to just remove monorepo dependencies from peerDependencies and keep them only in devDependencies?

[SimenB]

Yeah, we can do that as a start. It's still not the correct solution though as we rely on the api of the passed in module. It's a bigger chunk of work though, so just removing the peers should be ok as a start

[Hoishin]

I agree that this isn't the best solution. I'd be willing to look into the correct solution, but at least the warning should be solved with this PR.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.