use default cwd even if config contains a cwd property

[jeysal]

Summary

Fixes #7857, check that issue for details

Test plan

[SimenB]

I don't follow - shouldn't options just override default options?

[jeysal]

As I understand it, cwd is not a supported option for users to specify in the config. I mentioned in the issue that it does not appear in the docs or in InitialOptions

[SimenB]

@rubennorte you added it in #7146 - thoughts?

[jeysal]

(I also think it's right that it is not something that can be explicitly set, that should only be the case for rootDir)

[jeysal]

Either way, cwd becoming undefined if it is explicitly set is definitely not expected behavior 😅

[jeysal]

Updated to do this in a much cleaner way, don't know what I was thinking yesterday ^^

[codecov-io]

Codecov Report

Merging #7923 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #7923   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files         265      265           
  Lines       10534    10534           
  Branches     2557     2556    -1     
=======================================
  Hits         6564     6564           
  Misses       3387     3387           
  Partials      583      583

Impacted Files	Coverage Δ
packages/jest-config/src/Defaults.ts	100% <ø> (ø)	⬆️
packages/jest-config/src/ValidConfig.ts	100% <ø> (ø)	⬆️
packages/jest-config/src/normalize.ts	79.52% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ce3f3...cff4b4a. Read the comment docs.

[Aghassi]

@jeysal @SimenB Any movement on this? Anything I can help with so this can be merged? Would love to keep on top of the most current version of Jest and not be stuck because of #7857

[jeysal]

@Aghassi I think we're just waiting for @rubennorte who originally added cwd in some places to comment what on what the correct behavior would be. I think this is the correct solution because cwd is not and should not be a supported config option and should thus be ignored instead of breaking. The alternative would be to allow cwd to be overwritten in user config, which would also resolve the issue.
I think you could upgrade regardless of this issue though, if you just remove cwd from your config it should work?

[Aghassi]

@jeysal I'm actually never setting it explicitly. Seems like if I do delete config.cwd it works though. I will do that for now and note these issues.

EDIT: I lied it doesn't. Still digging in. Doesn't matter if I remove cwd. The default config has it, and also Jest still tries to validate it (which breaks if it is undefined). So... I can't upgrade unless I try overwriting the console object, which I don't feel is something I wish to spend time on right now. We will downgrade until there is a clear upgrade path.

[jeysal]

@Aghassi the reproduction repo you provided (https://github.com/Aghassi/oclif-jest-demo-failure/blob/master/jest.config.js) does set it though? And when I checked out that repo a week ago, the error went away after removing cwd

[Aghassi]

@jeysal Sorry, I was trying it on an internal repo and as far as I can tell we never set it. I was able to validate and realized I had deleted cwd from the wrong config. But even when I deleted the cwd from the config, it only seems to work when the repo is linked (we do something similar to fbjs internally where we store configs and then leverage them in multiple repos. So I'm definitely lost 😅

[jeysal]

Okay. I hope your internal repo doesn't surface a whole different issue than the reproduction then 😬

[Aghassi]

@jeysal For now, we are downgrading until the typescript changes are ironed out. Since we support larger systems, and I can't seem to figure out why beyond deleting cwd doesn't fix the problem, I want to wait. It's possible this change will resolve the problem and I'm just missing something on my end. However, since both seem to still run most tests fine, our developers won't be missing much. I have Renovate running internally so I will get a ping as soon as the next version gets published. I'll be testing each version to ensure I can upgrade without fail 😄 . Trust me, I don't want to be stuck. Just don't have many cycles to spend debugging this at the moment.

[Aghassi]

@rubennorte any chance you can chime in here? Ideally I’d like to be able to update to the latest jest, but am still blocked in part due to this.

[jeysal]

@SimenB do we absolutely need Ruben's input on this?
The purpose of #7146 was to move cwd assignment from jest-cli to jest-config. This is preserved here.
The second sentence over there states that cwd is added to the defaults so it can be imported from there in JS config. This is lost here, but I don't see why that's a problem - you can't set cwd in your config anyway, it doesn't work (and IMO shouldn't).
This PR just fixes the behavior when you try to set it - instead of cwd becoming undefined, it is just ignored like setting asdf in the config. I think this PR is just the right way of moving the assignment from jest-cli to jest-config like #7146 did.

[rubennorte]

@jeysal and @Aghassi sorry for the late reply, I've been a bit busy and some things starts to stack up.

This looks good. As @jeysal said, my main reason to add this change was to have it in jest-config and I see that allowing it in userland was a bad side-effect I wasn't counting on.

Thanks for the fix!

[jeysal]

Rebased (manually)

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.