Passed filePath to dependencyExtractor #7362
Conversation
rubennorte
force-pushed
the
pass-filename-to-dependency-extractor
branch
from
3dfc38b to
5e950de
Compare
rubennorte
force-pushed
the
pass-filename-to-dependency-extractor
branch
from
5e950de to
a5fc6e3
Compare
rubennorte
force-pushed
the
pass-filename-to-dependency-extractor
branch
from
a5fc6e3 to
a4b1e36
Compare
| const crypto = require('crypto'); | ||
|
|
||
| module.exports = { | ||
| extract(code, filePath, defaultExtract) { |
There was a problem hiding this comment.
Should we pass an object instead of multiple args? Or code as first, then an object?
There was a problem hiding this comment.
I would've preferred that (I generally prefer objects than positional arguments as they're easier to extend) but I favored consistency with the rest of the Jest codebase.
Now that we're considering how the configuration should be from now on, we can reach an agreement about this.
This isn't urgent so we can discuss this in a wider scope before merging.
|
@rubennorte land this? 🙂 |
rubennorte
force-pushed
the
pass-filename-to-dependency-extractor
branch
from
a4b1e36 to
efaa14f
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
The dependency extraction might depend on the filename (some Babel plugins dynamically add dependencies using the filename). This passes an additional parameter to the
extractmethod (which is breaking but this hasn't been released in any stable yet).Test plan
Updated unit and e2e tests.