Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize file names in packages/jest-diff #7238

Merged
merged 3 commits into from
Oct 22, 2018

Conversation

andrearosr
Copy link
Contributor

Summary

This is part of #4969 in follow-up to #6780.
It standardizes file names in packages/jest-diff under Facebook naming conventions.

Test plan

Running yarn run clean-all followed by yarn and yarn test is not completely clean on my machine, but it yields the same results in this branch and master

@SimenB
Copy link
Member

SimenB commented Oct 22, 2018

Thanks! Hopefully CI triggers at some point, so we can verify this and land it.

In the meantime, mind updating the changelog? Under chore is fine 🙂

@SimenB SimenB merged commit cdf7a22 into jestjs:master Oct 22, 2018
@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #7238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7238   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files         237      237           
  Lines        9317     9317           
  Branches        3        3           
=======================================
  Hits         6201     6201           
  Misses       3115     3115           
  Partials        1        1
Impacted Files Coverage Δ
...kages/jest-circus/src/format_node_assert_errors.js 16.27% <ø> (ø) ⬆️
packages/jest-diff/src/diffStrings.js 100% <ø> (ø)
packages/jest-diff/src/index.js 82.5% <ø> (ø) ⬆️
packages/jest-jasmine2/src/assert_support.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47cde7f...9b6f030. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants