Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for 23.1, 23.2, and 23.3 #6623

Merged
merged 4 commits into from
Jul 5, 2018

Conversation

rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Jul 4, 2018

Summary

This PR adds missing docs for previous versions and bumps latest on the site to 23.3

Verified

This commit was signed with the committer’s verified signature.
@SimenB
Copy link
Member

SimenB commented Jul 4, 2018

Needs a yarn lint:md

Verified

This commit was signed with the committer’s verified signature.
@yangshun
Copy link
Contributor

yangshun commented Jul 4, 2018

Website preview on Netlify has been added. For this PR, the preview is available at https://deploy-preview-6623--jest-preview.netlify.com/

Moving forward, all Jest previews for PRs can be found at https://deploy-preview-<PR_NUMBER>--jest-preview.netlify.com/. We wouldn't integrate the bot to comment the preview links, but the collaborators can make a mental note of that, or find the preview link in the checks section all the way at the bottom. Hopefully, this integration helps to catch documentation bugs earlier if any! 😄

screen shot 2018-07-04 at 1 13 32 pm

cc @endiliey @JoelMarcey

@rickhanlonii
Copy link
Member Author

BEAUTY THANKS @yangshun

Verified

This commit was signed with the committer’s verified signature.
# Conflicts:
#	CHANGELOG.md
@SimenB
Copy link
Member

SimenB commented Jul 4, 2018

@yangshun that's awesome!

The search doesn't work, but maybe that's expected?

image

api-key=undefined

@JoelMarcey
Copy link
Contributor

@SimenB Right. I believe search won't work because the there is no relationship (canonical or redirect) from the Netlify site to the actual Jest site.

@endiliey
Copy link
Contributor

endiliey commented Jul 5, 2018

Caused by this
https://github.com/facebook/jest/blob/c6512ad1b32a5d22aab9937300aa61aa87f76a27/website/siteConfig.js#L114

Unlike docusaurus, the algolia api key is hidden in jest. We can consider exposing it. Its easily found on chrome devtools - check the algolia query network at jestjs.io by the way

833906d7486e4059359fa58823c4ef56
api

Edit: You might want to change
https://github.com/facebook/jest/blob/c6512ad1b32a5d22aab9937300aa61aa87f76a27/website/siteConfig.js#L117

to 23.3 as well.

Verified

This commit was signed with the committer’s verified signature.
@codecov-io
Copy link

Codecov Report

Merging #6623 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6623   +/-   ##
=======================================
  Coverage   63.73%   63.73%           
=======================================
  Files         235      235           
  Lines        8935     8935           
  Branches        4        3    -1     
=======================================
  Hits         5695     5695           
  Misses       3239     3239           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6512ad...43524cd. Read the comment docs.

@rickhanlonii rickhanlonii requested a review from SimenB July 5, 2018 14:42
@SimenB
Copy link
Member

SimenB commented Jul 5, 2018

Why in the name of every diety is the approve button at the bottom on mobile? I literally scrolled for a minute waiting for the stupid radio button to render.

Old fashioned LGTM (looked at the new commits instead)

@endiliey
Copy link
Contributor

endiliey commented Jul 5, 2018

Sorry for the trouble of manually adding the version number.

facetFilters: ['language:LANGUAGE', 'version:23.3'], 

When we release Docusaurus 1.3.2, let's update jest docusaurus & automatically search the correct version depending on user's current chosen version with

facetFilters: ['language:LANGUAGE', 'version:VERSION'], 

It will be easier to debug the cause of broken gh-pages branch on 1.3.2 as well. Although seems to me there is no website down now on jest 😂

@rickhanlonii
Copy link
Member Author

No worry, that sounds like a great feature @endiliey

Thanks @SimenB

@rickhanlonii rickhanlonii merged commit 01f28ef into jestjs:master Jul 5, 2018
@rickhanlonii rickhanlonii deleted the rh-add-docs branch July 5, 2018 15:08
schalkneethling referenced this pull request in mdn/interactive-examples Jul 6, 2018
This Pull Request renovates the package group "jest monorepo".


-   [jest-environment-node](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0`
-   [jest](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0`

# Release Notes
<details>
<summary>facebook/jest</summary>

### [`v23.3.0`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#&#8203;2330)
[Compare Source](jestjs/jest@v23.2.0...v23.3.0)
##### Features

- `[jest-cli]` Allow watch plugin to be configured ([#&#8203;6603](`https://github.com/facebook/jest/pull/6603`))
- `[jest-snapshot]` Introduce `toMatchInlineSnapshot` and `toThrowErrorMatchingInlineSnapshot` matchers ([#&#8203;6380](`https://github.com/facebook/jest/pull/6380`))
##### Fixes

- `[jest-regex-util]` Improve handling already escaped path separators on Windows ([#&#8203;6523](`https://github.com/facebook/jest/pull/6523`))
- `[jest-cli]` Fix `testNamePattern` value with interactive snapshots ([#&#8203;6579](`https://github.com/facebook/jest/pull/6579`))
- `[jest-cli]` Fix enter to interrupt watch mode ([#&#8203;6601](`https://github.com/facebook/jest/pull/6601`))
##### Chore & Maintenance

- `[website]` Switch domain to https://jestjs.io ([#&#8203;6549](`https://github.com/facebook/jest/pull/6549`))
- `[tests]` Improve stability of `yarn test` on Windows ([#&#8203;6534](`https://github.com/facebook/jest/pull/6534`))
- `[*]` Transpile object shorthand into Node 4 compatible syntax ([#&#8203;6582](`https://github.com/facebook/jest/pull/6582`))
- `[*]` Update all legacy links to jestjs.io ([#&#8203;6622](`https://github.com/facebook/jest/pull/6622`))
- `[docs]` Add docs for 23.1, 23.2, and 23.3 ([#&#8203;6623](`https://github.com/facebook/jest/pull/6623`))
- `[website]` Only test/deploy website if relevant files are changed ([#&#8203;6626](`https://github.com/facebook/jest/pull/6626`))
- `[docs]` Describe behavior of `resetModules` option when set to `false` ([#&#8203;6641](`https://github.com/facebook/jest/pull/6641`))

---


</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants