Don't escape hyphens for Regex

[insin]

This fixes facebook/create-react-app#542 for me locally

[cpojer]

Hmmm.. I'm trying to figure out if we need to ever escape hyphen when we always escape square brackets – I think not. This is probably whatever people on stack overflow recommend to use and I think it might be flawed :)

cc @davidaurelio what do you think?

[insin]

Hmmm.. I'm trying to figure out if we need to ever escape hyphen when we always escape square brackets – I think not.

Agreed, as hyphens are only "special" inside square brackets, and even then it depends on where the hyphen is (thanks, Regexps!)

The obligatory @sindresorhus module doesn't escape them either: https://github.com/sindresorhus/escape-string-regexp/blob/master/index.js 😸

[cpojer]

awesome, thank you so much for the quick fix. I'll publish a fix for Jest tomorrow morning.

This also fixes #1551.

[codecov-io]

Current coverage is 90.29% (diff: 100%)

Merging #1574 into master will not change coverage

@@             master      #1574   diff @@
==========================================
  Files            28         28          
  Lines          1123       1123          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1014       1014          
  Misses          109        109          
  Partials          0          0          

Powered by Codecov. Last update 3e141f0...c43fb67

[pavlin99th]

I ended up with the exact same fix for windows.
What about other special symbols? Someone crazy may create folder a[x-z]$c.

[cpojer]

We'll figure out where to go from here and how to put a lasting fix in place. We are still working on getting Jest's tests onto AppVeyor.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.