fix(@jest/resolve): Include stringifiedOptions in getModuleIDAsync

[maxdavidson]

Summary

I use native ESM with the --experimental-vm-modules flag. When upgrading to Jest 28, jest.unstable_mockModule stopped working:

  jest.unstable_mockModule("../src/config/oidc.js", () => ({
    OIDC_CLIENT_ID: clientId,
    OIDC_CLIENT_SECRET: clientSecret,
    OIDC_ISSUER_URL: issuerUrl,
  }));

  // Not resolving the transitive mocked module in Jest 28!
  const authHandlers = await import("../src/handlers/oidc.js");

I tracked this down to the mock detection failing due to getModuleID and getModuleIDAsync not generating identical IDs. In this case getModuleIDAsync did not append the stringified options, so the lookup using the ID as a key failed.

There are other slight differences between getModuleID and getModuleIDAsync that might lead to similar issues.

Test plan

• jest.unstable_mockModule followed by a dynamic import should resolve the mocked module

[SimenB]

oh, good catch! would you be able to add a test as well?

(and a changelog entry)

There are other slight differences between getModuleID and getModuleIDAsync that might lead to similar issues.

We should fix those. Is it possible to extract some utils to keep it DRY?

[maxdavidson]

oh, good catch! would you be able to add a test as well?
(and a changelog entry)

Sure, I'll make an attempt 👍

There are other slight differences between getModuleID and getModuleIDAsync that might lead to similar issues.

We should fix those. Is it possible to extract some utils to keep it DRY?

I can look into it 👍

[SimenB]

Fantastic, thanks!

[SimenB]

https://github.com/facebook/jest/releases/tag/v28.0.3

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.