fix: deprecate jest-serializer
#12391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
deprecated-jest-serializer
branch
from
d900865
to
db88da0
Compare
|
Good move. Wondering, if perhaps it is time to retire |
|
Yeah, good call. Let's do the same thing (releasing a v28, then deprecate it) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since #8455 (https://github.com/facebook/jest/pull/8455/files#r314608524) this package has just been a thin facade over
v8APIs, so it serves no real purpose.I'll keep the source code until the Jest 28 stable release, at which point I'll deprecate that version (so people stuck on 27 or older do not see the warning. There's nothing wrong with 27, it's just unneeded) and delete the source.
Test plan
Green CI