[jest-worker] Don't pass explicit env to new Worker when using worker_threads
#12141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LIZE` with `worker_threads`
Codecov Report
@@ Coverage Diff @@
## main #12141 +/- ##
=======================================
Coverage 67.71% 67.71%
=======================================
Files 328 328
Lines 16990 16991 +1
Branches 4817 4817
=======================================
+ Hits 11505 11506 +1
Misses 5452 5452
Partials 33 33
Continue to review full report at Codecov.
|
nicolo-ribaudo
commented
Dec 11, 2021
packages/jest-worker/src/workers/__tests__/NodeThreadsWorker.test.js
Outdated
Show resolved
Hide resolved
nicolo-ribaudo
commented
Dec 11, 2021
packages/jest-worker/src/workers/__tests__/NodeThreadsWorker.test.js
Outdated
Show resolved
Hide resolved
nicolo-ribaudo
commented
Dec 11, 2021
nicolo-ribaudo
commented
Dec 11, 2021
|
Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#12128 wasn't enough to fix the regression introduced by #12069: it was still broken when using the
NODE_OPTIONSenv var because of nodejs/node#41103 (comment).Test plan
I updated the existing tests, but I would have loved if they were not all mock-based but spawned real workers 😅