fix(jest-types): compat with @types/node v16

[splincode]

#11640

[facebook-github-bot]

Hi @splincode!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[splincode]

CLA signed

[codecov-commenter]

Codecov Report

Merging #11645 (3652958) into master (315784d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #11645   +/-   ##
=======================================
  Coverage   69.01%   69.01%           
=======================================
  Files         312      312           
  Lines       16335    16335           
  Branches     4734     4734           
=======================================
  Hits        11273    11273           
  Misses       5034     5034           
  Partials       28       28           

Impacted Files	Coverage Δ
packages/jest-fake-timers/src/legacyFakeTimers.ts	94.95% <ø> (ø)
packages/jest-fake-timers/src/modernFakeTimers.ts	85.96% <ø> (ø)
packages/jest-jasmine2/src/pTimeout.ts	100.00% <ø> (ø)
packages/jest-jasmine2/src/queueRunner.ts	100.00% <ø> (ø)
packages/jest-mock/src/index.ts	84.98% <ø> (ø)
packages/jest-util/src/setGlobal.ts	0.00% <ø> (ø)
packages/jest-console/src/BufferedConsole.ts	75.32% <100.00%> (ø)
packages/jest-console/src/CustomConsole.ts	81.69% <100.00%> (ø)
packages/jest-runtime/src/index.ts	58.77% <100.00%> (ø)
packages/jest-util/src/installCommonGlobals.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315784d...3652958. Read the comment docs.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[72636c]

Our CI picked up a few other references across the packages:

node_modules/@jest/console/build/BufferedConsole.d.ts(15,21): error TS2694: Namespace 'NodeJS' has no exported member 'ConsoleConstructor'.
node_modules/@jest/console/build/BufferedConsole.d.ts(23,45): error TS2694: Namespace 'NodeJS' has no exported member 'InspectOptions'.
node_modules/@jest/console/build/CustomConsole.d.ts(18,21): error TS2694: Namespace 'NodeJS' has no exported member 'ConsoleConstructor'.
node_modules/@jest/console/build/CustomConsole.d.ts(26,45): error TS2694: Namespace 'NodeJS' has no exported member 'InspectOptions'.
node_modules/@jest/fake-timers/build/legacyFakeTimers.d.ts(15,43): error TS2694: Namespace 'NodeJS' has no exported member 'Global'.
node_modules/@jest/fake-timers/build/modernFakeTimers.d.ts(17,24): error TS2694: Namespace 'NodeJS' has no exported member 'Global'.
node_modules/@jest/types/build/Config.d.ts(312,38): error TS2694: Namespace 'NodeJS' has no exported member 'Global'.
node_modules/@jest/types/build/Global.d.ts(93,62): error TS2694: Namespace 'NodeJS' has no exported member 'Global'.
node_modules/jest-mock/build/index.d.ts(8,30): error TS2694: Namespace 'NodeJS' has no exported member 'Global'.

[splincode]

@72636c hi, fixed ))

[splincode]

@SimenB please, help me about problem with #11640

[mrcnski]

Can a maintainer please provide an update on this? This is causing ecosystem-wide disruption. I've documented only a few instances here.

Also, what is being done to ensure that this does not occur again in the future?

[JustFly1984]

Having issues with ts checking too with errors:

Namespace 'NodeJS' has no exported member 'ConsoleConstructor'
Namespace 'NodeJS' has no exported member 'InspectOptions'

[rkesters]

@SimenB @jest-bot Please review

[rkesters]

@SimenB bump, status?

[rkesters]

@cpojer please review.

[artekr]

Any updates for this fix?

[SimenB]

Thanks! Could you add a changelog entry?

Also, weird that GH Actions hasn't triggered... Maybe a new commit with a changelog fixes it 🙂

[splincode]

Could you add a changelog entry? I didn't quite understand what needs to be done)

[SimenB]

Add an entry here describing your change: https://github.com/facebook/jest/blob/master/CHANGELOG.md

[splincode]

@SimenB hello, I was updated branch, please review me

[splincode]

@SimenB hello, I was updated branch after review))

[SimenB]

Thanks @splincode!

[SimenB]

https://github.com/facebook/jest/releases/tag/v27.1.0

[harelmo]

Is this a breaking change? it seems like Global is now defined as:

export interface Global extends GlobalAdditions, Omit<typeof globalThis, keyof GlobalAdditions> {
    [extras: string]: unknown;
}

breaking our existing declaration of variables set to this.global of the NodeEnvironment:

declare global {
  namespace NodeJS {
    interface Global {
      driver: TestDriver;
      reset(): Promise<void>;
    }
  }
}

class ITEnvironment extends NodeEnvironment {
  async setup(): Promise<void> {
    await super.setup();

    this.global.driver = new TestDriver(...);

    this.global.reset = async () => {
      await this.global.driver.reset();
    };
  }
}
...

that used to work fine until now, but now we're getting:

error TS2571: Object is of type 'unknown'.

           await this.global.driver.reset();
                 ~~~~~~~~~~~~~~~~~~

with jest ~27.1.0 and @types/node at 14.14.0.

Is this by design? are typed exports from global not supported anymore?

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.