Use git diff instead of git log for --changedSince

[finn-orsini]

Summary

Addresses issue described in #9602, where files with no difference are marked as changed by using git log instead of git diff for the --changedSince flag option.

Test plan

• All existing git --changedSince specs pass
• Added spec for the case described in changedSince runs specs related to files with no diff #9602, where the committed changes have no diff, verifies no file names returned from getChangedFilesForRoots.

Note: Seeing failures on local master branch with message abort: empty revision range for jestChangedFiles: gets changed files for hg and onlyChanged: gets changed files for hg specs after running brew install hg successfully.

[SimenB]

I think this makes sense (as discussed in the issue). Thanks for sending a PR!

/cc @jeysal @thymikee @cpojer any final thoughts?

---

Regarding the Mercurial tests, I haven't had them pass for at least a year (and they're skipped on CI) so feel free to ignore them

[matthew-hallsworth]

Can we get an update as to when this might be merged and released? I have a few things in our company test pipeline that rely upon this change :)

Thanks!

[alsuren]

This looks like it will do the right thing in all of the cases that I care about (including when branches diverge). Thanks for taking this on.

[SimenB]

Good enough for me. Thanks @finn-orsini!

[pelotom]

Any chance this could get released soon? This is a major blocker for us since we can't practically run all of our tests in CI on every PR.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.