chore(jest-console): migrate function signature #10126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Stuck it in the milestone so we don't forget 🙂 |
|
@ychi CI is very unhappy - could you rebase this? |
ychi
force-pushed
the
migrate-getconsoleoutput-signature
branch
from
b1476b4
to
fae4c87
Compare
|
Rebased; looks like latest macOS image is lacking Mercurial? |
|
Thanks!
There's some unrelated macOS flake - I need to look into that |
SimenB
approved these changes
Nov 15, 2020
SimenB
changed the title
|
Added to |
This was referenced Dec 5, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR for #10112
The breaking changes to
getConsoleOutput: removing unused parameter, making new parameters mandatory.Test plan
Pass existing test cases.