Remove mocksPattern, rename testPathDirs to roots. #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Feb 1, 2017
docs/Configuration.md
Outdated
|
|
||
| There are times where you only want Jest to search in a single sub-directory (such as cases where you have a `src/` directory in your repo), but prevent it from accessing the rest of the repo. | ||
|
|
||
| *Note: While `rootDir` is mostly used as a token to be re-used in other configuration options, `roots` is used by the internals of Jest to locate test files and source files. By default, `roots` has a single entry `<rootDir>` but there are cases where you want to have multiple roots within one project, for example `roots: ["<rootDir>/src/", "<rootDir>/tests/"]`.* |
There was a problem hiding this comment.
I'd bold this phrase: "locate test files and source files"
thymikee
reviewed
Feb 1, 2017
| } | ||
|
|
||
| Please update your configuration. | ||
| `, |
There was a problem hiding this comment.
We should also mention deprecating mocksPattern
There was a problem hiding this comment.
Nobody can use it because it is broken, so I'd rather just kill it directly.
thymikee
reviewed
Feb 1, 2017
| @@ -11,11 +11,11 @@ | |||
|
|
|||
| const path = require('path'); | |||
|
|
|||
| const mocksPattern = '__mocks__'; | |||
| const MOCKS_PATTERN = path.sep + '__mocks__' + path.sep; | |||
There was a problem hiding this comment.
Maybe we could hoist MOCKS_PATTERN it to jest-util? It appears in 2 packages and 3 different places.
There was a problem hiding this comment.
I don't want jest-haste-map to depend on jest-util.
|
@cpojer I've removed mocksPattern in this PR #2705 * comment: #2705 (comment)
|
cpojer
force-pushed
the
master
branch
2 times, most recently
from
d9b69cd to
e44cbee
Compare
|
finally managed to find some time to fix things here. |
Codecov Report
@@ Coverage Diff @@
## master #2776 +/- ##
=========================================
Coverage ? 67.65%
=========================================
Files ? 140
Lines ? 5076
Branches ? 0
=========================================
Hits ? 3434
Misses ? 1642
Partials ? 0
Continue to review full report at Codecov.
|
mthmulders
added a commit
to mthmulders/stryker-jest-runner
that referenced
this pull request
Feb 10, 2017
This in preparation of future Jest versions (> 18.1) that will have `testPathDirs` renamed to `roots`. See jestjs/jest#2776.
nicojs
pushed a commit
to stryker-mutator/stryker-jest-runner
that referenced
this pull request
Feb 10, 2017
* chore: remove some template files from the plugin-seed * chore: update project files for newer Stryker version * chore(doc): Show correct Travis badge * test(all): Add sample project for running integration tests * fix(build) Explicitly list jest-runtime as dep * fix(TestRunner): Add testPathDirs option Add `testPathDirs` option to the jest test runner options in order to make it work on the windows platform. I'm not jet sure that `process.cwd()` is the correct value, but it seems to work for now. * chore(build) Do not attempt to run on Node < 6.0.0 * fix(runner) Also specify `roots` option This in preparation of future Jest versions (> 18.1) that will have `testPathDirs` renamed to `roots`. See jestjs/jest#2776.
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* Remove mocksPattern config. * Rename `testPathDirs` to `roots`. * Fix mocks pattern.
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Remove mocksPattern config. * Rename `testPathDirs` to `roots`. * Fix mocks pattern.
sanderkoenders
pushed a commit
to stryker-mutator/stryker-js
that referenced
this pull request
Jul 6, 2018
* chore: remove some template files from the plugin-seed * chore: update project files for newer Stryker version * chore(doc): Show correct Travis badge * test(all): Add sample project for running integration tests * fix(build) Explicitly list jest-runtime as dep * fix(TestRunner): Add testPathDirs option Add `testPathDirs` option to the jest test runner options in order to make it work on the windows platform. I'm not jet sure that `process.cwd()` is the correct value, but it seems to work for now. * chore(build) Do not attempt to run on Node < 6.0.0 * fix(runner) Also specify `roots` option This in preparation of future Jest versions (> 18.1) that will have `testPathDirs` renamed to `roots`. See jestjs/jest#2776.
sanderkoenders
pushed a commit
to stryker-mutator/stryker-js
that referenced
this pull request
Jul 6, 2018
The roots and testPathDirs attributes of the configuration passed to Jest may both be left undefined. This has the added advantage of continuing to work once testPathDirs has been deprecated in Jest 19.0.0. See jestjs/jest#2776
nicojs
pushed a commit
to stryker-mutator/stryker-js
that referenced
this pull request
Jul 8, 2018
* chore: remove some template files from the plugin-seed * chore: update project files for newer Stryker version * chore(doc): Show correct Travis badge * test(all): Add sample project for running integration tests * fix(build) Explicitly list jest-runtime as dep * fix(TestRunner): Add testPathDirs option Add `testPathDirs` option to the jest test runner options in order to make it work on the windows platform. I'm not jet sure that `process.cwd()` is the correct value, but it seems to work for now. * chore(build) Do not attempt to run on Node < 6.0.0 * fix(runner) Also specify `roots` option This in preparation of future Jest versions (> 18.1) that will have `testPathDirs` renamed to `roots`. See jestjs/jest#2776.
nicojs
pushed a commit
to stryker-mutator/stryker-js
that referenced
this pull request
Jul 8, 2018
The roots and testPathDirs attributes of the configuration passed to Jest may both be left undefined. This has the added advantage of continuing to work once testPathDirs has been deprecated in Jest 19.0.0. See jestjs/jest#2776
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in #2600.
Test plan
jest