-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] GraphQL Schema Definition Language (SDL) #90
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
1d8a1dd
[RFC] GraphQL IDL additions
leebyron 7401ede
Add directives to all schema definition forms
leebyron 468656d
expose more in example directive
leebyron 5f420d5
Include more directive locations
leebyron 680a35c
Include deprecated directive
leebyron 0a6b056
Note on omission of schema definition
leebyron e575ac8
Explicit ObjectTypeExtension grammar to support extending without add…
leebyron eeb1a2c
Ensure directives cannot reference variables in SDL
leebyron edc0af2
grammar
leebyron 03622db
Remove duplicate EnumValue
leebyron 58dc082
First class descriptions
leebyron 628845c
Minor wording change about markdown and TSL -> SDL
leebyron 4559eca
Add validation rule that executable documents cannot include SDL
leebyron 7d1b700
Move extend keyword
leebyron 6070aec
Order of sections
leebyron 4b5f7ea
Move language definitions into Type System section
leebyron b94438e
Fix type reference header and comments
leebyron d6919ce
Add more examples of descriptions
leebyron d39cad3
Grammar
leebyron afb50d6
Include optional leading bar for unions & directive locations. Mergin…
leebyron bde02b9
Allow partial definitions (as @OlegIlyenko suggests) while legitimizi…
leebyron 786a0e2
Consistent plural usage in grammar nt rules
leebyron 85ffa8f
Remove ambiguous "may not" and explicitly state objects may implement…
leebyron e607dcc
Extract ExecutableDefinition into a separate gramatical rule
leebyron aeada74
Address review from @vergenzt
leebyron 0444c3e
Use `&` to separate implemented interfaces, simplify grammar definitions
leebyron 5552659
Fix reference in grammar summary
leebyron 27d59b7
Fix reference to UnionMemberTypes
leebyron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I am reading the grammar syntax wrong but does this allow a preceding '&' after the implements keyword
or
I would expect it to have no
&
after theimplements
keywordAnd hence
or
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it for this case (aka formatting??)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again it might be I am reading the grammar decl wrong but currently I think it allows
(because of the repeating ??)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbakerman Yes leading
&
supported for formatting more context here: #323No, it doesn't. According to the grammar
implements
can be used only in the beginning.