Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExifInterface: Invalid image. #1558

Closed
hpdx opened this issue Nov 29, 2016 · 9 comments
Closed

ExifInterface: Invalid image. #1558

hpdx opened this issue Nov 29, 2016 · 9 comments
Labels

Comments

@hpdx
Copy link

hpdx commented Nov 29, 2016

11-29 14:38:58.418 27599-27644/? W/ExifInterface: Invalid image.
java.io.IOException: Invalid marker: 89
at android.media.ExifInterface.getJpegAttributes(ExifInterface.java:1612)
at android.media.ExifInterface.loadAttributes(ExifInterface.java:1335)
at android.media.ExifInterface.(ExifInterface.java:1053)
at com.facebook.imagepipeline.producers.LocalExifThumbnailProducer.getExifInterface(LocalExifThumbnailProducer.java:136)
at com.facebook.imagepipeline.producers.LocalExifThumbnailProducer$1.getResult(LocalExifThumbnailProducer.java:103)
at com.facebook.imagepipeline.producers.LocalExifThumbnailProducer$1.getResult(LocalExifThumbnailProducer.java:97)
at com.facebook.common.executors.StatefulRunnable.run(StatefulRunnable.java:45)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:818)

@massimocarli
Copy link
Contributor

Hi @hpdx ,
Can you provide us the image Url please?
Thanks

@massimocarli massimocarli added the needs-details This issue or PR is currently not actionable as it misses details (e.g. for reproducing the problem) label Nov 29, 2016
@ChenSiLiang
Copy link

ChenSiLiang commented Dec 14, 2016

same issue.
@massimocarli It seems this native method return null
nativeGetRawAttributesFromFileDescriptor() in ExifInterface.class.
So handleRawResult() return false and it call getJpegAttributes(in),in fact it is not a JPEG

@lambdapioneer
Copy link
Contributor

@ChenSiLiang can you provide us with a sample image file that shows the described behavior? That would allow us to verify the fix and add unit tests to avoid regressing this.

@ChenSiLiang
Copy link

ChenSiLiang commented Dec 15, 2016

sure, like this.
cat_185 1
tips:fresco 0.14.1, nexus 5x, android 7.1.1

@hzw1199
Copy link

hzw1199 commented Feb 1, 2017

I find this to be solved in fresco 1.0.1

@erikandre
Copy link

Closing issue as the problem is reported to be solved :)

@kirwan
Copy link
Contributor

kirwan commented May 17, 2017

I don't think this was actually solved as it's been reported again in #1760.

The key thing which I think was missed before is that the image is a PNG and EXIF data is only available in JPEGs.

@kirwan kirwan added bug and removed needs-details This issue or PR is currently not actionable as it misses details (e.g. for reproducing the problem) labels May 17, 2017
@kirwan kirwan reopened this May 17, 2017
@farwayer
Copy link

@kirwan I just trapped into this issue with React Native in combination with CodePush. Is any chance new version with fix will be released soon?

@kirwan
Copy link
Contributor

kirwan commented Jul 17, 2017

This is now fixed in Fresco 1.4.0. @farwayer if this is causing a problem for you with React Native, we'll need to get that updated to use 1.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants