-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG.md for 0.7.0 #97
Conversation
@zpao what's your thinking around the timeline for 0.7.0? @skevy's recent fbjs diffs fix some RN issues people are having (facebook/react-native#5467 is one of the top bugs -- skevy tells me his fbjs changes + some RN packager changes should resolve it) and allow Relay to work with RN. So the earlier we get a new fbjs release the sooner RN can ship with Relay compat. |
I meant to followup on this sooner, sorry. So I guess the question is, how will the cascading of fbjs versions work? I know we updated fbemitter explicitly to get all the RN deps using 0.6. But we aren't going to upgrade React for every fbjs release so that's not a maintainable approach. |
Part of the fbjs and packager changes are to ignore some of the providesModule declarations so I think it'll be fine if there are multiple copies of fbjs. It might be necessary for react and fbemitter to upgrade to 0.7 one time (I don't think so though). |
Yeah, starting with RN 0.19 it's fine to have more than one fbjs. |
@zpao, @spicyj we're blocked to land facebook/react-native#5084 up until a new release of fbjs is done (unless we depend on a commit, which I guess is not ideal, right?). There's no rush, just wanted to get an idea when you were planning to release the next version :) |
Also, it's in the changelog, but #100 should be pulled in as well. |
Depending on the commit would actually be a good way to move forward but fbjs has some prepublishing scripts so we need to grab it from npm. |
@zpao Any update on the timeline ? Sorry to sound impatient but I am kinda excited to see the day where Relay and RN just work together. Thanks in advance. |
Gonna take a closer look at things today. |
Thanks @zpao! |
This is just a placeholder with a list of changes since 0.6.0. We can update / replace it when 0.7.0 is actually published.
cc @zpao