Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable standard Facebook Login on a Mac Catalyst app, avoiding fallback to the Limited Login flow #2522

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable standard Facebook Login on a Mac Catalyst app, avoiding fallback to the Limited Login flow #2522

wants to merge 2 commits into from
+80 −0

Conversation

Csaba8472
Copy link

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Fix for #2498

Enable standard Facebook Login on a Mac Catalyst app, avoiding fallback to the Limited Login flow.

Test Plan

  • Build the app with Mac Catalyst.
  • Initiate the Facebook login flow.
  • SDK should start the standard login flow

@Csaba8472 Csaba8472 requested a review from joesus as a code owner January 4, 2025 14:36
FahimGhafoori
FahimGhafoori reviewed Jan 10, 2025
View reviewed changes
Copy link

@FahimGhafoori FahimGhafoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract

@kingson8210
Copy link

Fodboldbane

kingson8210
kingson8210 reviewed Jan 14, 2025
View reviewed changes
Copy link

@kingson8210 kingson8210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fodboldbane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingson8210 kingson8210 kingson8210 left review comments

@FahimGhafoori FahimGhafoori FahimGhafoori left review comments

@joesus joesus Awaiting requested review from joesus joesus is a code owner

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Csaba8472 @kingson8210 @FahimGhafoori @facebook-github-bot