From a5ae682cf1ca48b9f35146aaa4934d0ac4efd72e Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Fri, 13 Dec 2024 10:53:22 -0800 Subject: [PATCH] Make ViewController nullable param in reauthorizeDataAccess (#2477) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: To help us review the request, please complete the following: - [x] sign [contributor license agreement](https://code.facebook.com/cla) - [x] I've ensured that all existing tests pass and added tests (when/where necessary) - [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary) - [ ] I've added the proper label to this pull request (e.g. `bug` for bug fixes) ## Pull Request Details 👋 hello from the [react-native-fbsdk-next](https://github.com/thebergamo/react-native-fbsdk-next) maintainer 😄 I would like the `reauthorizeDataAccess` ViewController param to conform to the nullability documented for it, and acceptable to the methods it passes the param to Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/2477 Test Plan: Untested (not entirely true, we've been [actively sending nil through this API](https://github.com/thebergamo/react-native-fbsdk-next/pull/204/files#diff-17f183fc0de77f22952fc0fddd688c62adde2533c3dc32798d9f836390f08454R110) since [our first implementation using the API](https://github.com/thebergamo/react-native-fbsdk-next/pull/204), and it's worked fine) Fixes https://github.com/facebook/facebook-ios-sdk/issues/2476 Differential Revision: D67113142 Pulled By: yuriy-tolstoguzov fbshipit-source-id: 5fdc24b84cb2e10caceb928eb6df123452a0e66e --- FBSDKLoginKit/FBSDKLoginKit/LoginManager.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FBSDKLoginKit/FBSDKLoginKit/LoginManager.swift b/FBSDKLoginKit/FBSDKLoginKit/LoginManager.swift index 85233c919..b7ed3231d 100644 --- a/FBSDKLoginKit/FBSDKLoginKit/LoginManager.swift +++ b/FBSDKLoginKit/FBSDKLoginKit/LoginManager.swift @@ -303,7 +303,7 @@ public final class LoginManager: NSObject { */ @objc(reauthorizeDataAccess:handler:) public func reauthorizeDataAccess( - from viewController: UIViewController, + from viewController: UIViewController?, handler: @escaping LoginManagerLoginResultBlock ) { guard