Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Remove references to React lifecycle methods deprecated in 16.3 #1940

Closed
claudiopro opened this issue Nov 20, 2018 · 2 comments
Closed

Remove references to React lifecycle methods deprecated in 16.3 #1940

claudiopro opened this issue Nov 20, 2018 · 2 comments
Labels
good first issue

Comments

@claudiopro
Copy link
Contributor

claudiopro commented Nov 20, 2018 •
edited
Loading

React components in Draft.js still use or reference lifecycle methods that were deprecated in React 16.3 because if misused, they can get in the way of asynchronous rendering.

The deprecated methods are:

componentWillMount
componentWillReceiveProps
componentWillUpdate

This post on the React blog provides an excellent migration guide and offers common scenarios with recipes to replace the legacy lifecycle methods with the new API.

It seems we only have references in examples or in code comments, so this makes it an easy first bug!
@claudiopro claudiopro changed the title Migrate React lifecycle methods deprecated in 16.3 Remove references to React lifecycle methods deprecated in 16.3 Nov 20, 2018
@seadeep42 seadeep42 mentioned this issue Dec 6, 2018
Closed
facebook-github-bot pushed a commit that referenced this issue Jan 21, 2019
@facebook-github-bot
Remove componentWillReceiveProps usages in examples (#1952)
363f66e 
Summary:
**Summary**
Resolves [1940](#1940)
Change usage of `componentWillReceiveProps` in Tex examples to `componentDidUpdate`
Pull Request resolved: #1952

Reviewed By: claudiopro

Differential Revision: D13417818

Pulled By: claudiopro

fbshipit-source-id: b13ff3140c3207cddaeb8d98c239f7dfd4b04a47
@danedavid
Copy link

Can I take this one up?

@claudiopro
Copy link
Contributor Author

Hi @danedavid, thanks for taking a look! I am afraid this issue is closed already with #1952. Please check back again for issues tagged with "good first issue".

jdecked pushed a commit to twitter-forks/draft-js that referenced this issue Oct 9, 2019
@jdecked
Remove componentWillReceiveProps usages in examples (facebookarchive#…
952406e 
…1952)

Summary:
**Summary**
Resolves [1940](facebookarchive#1940)
Change usage of `componentWillReceiveProps` in Tex examples to `componentDidUpdate`
Pull Request resolved: facebookarchive#1952

Reviewed By: claudiopro

Differential Revision: D13417818

Pulled By: claudiopro

fbshipit-source-id: b13ff3140c3207cddaeb8d98c239f7dfd4b04a47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claudiopro @danedavid