Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: adjust Lighthouse CI #7324

Merged
merged 3 commits into from
May 4, 2022
Merged

misc: adjust Lighthouse CI #7324

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18b365c
misc: adjust Lighthouse CI
lex111 May 4, 2022
5a2ab85
Use MD link
lex111 May 4, 2022
b8523ec
Format code
lex111 May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lighthouse-report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
with:
urls: |
https://deploy-preview-$PR_NUMBER--docusaurus-2.netlify.app/
https://deploy-preview-$PR_NUMBER--docusaurus-2.netlify.app/docs/
https://deploy-preview-$PR_NUMBER--docusaurus-2.netlify.app/docs/installation
configPath: ./.github/workflows/lighthouserc.json
uploadArtifacts: true
temporaryPublicStorage: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scripts/format-lighthouse-score.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const createMarkdownTableRow = ({

const createSingleRow = ({summary, testUrl, reportPublicUrl}) => {
const normalizedBody = {
url: testUrl,
url: new URL(testUrl).pathname,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a Markdown link, so we can click and go to the actual URL.

performance: scoreEntry(summary.performance),
accessibility: scoreEntry(summary.accessibility),
bestPractices: scoreEntry(summary['best-practices']),
Expand Down